Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reordering tabs still crashes when running elevated #5564

Closed
DJackman123 opened this issue Apr 25, 2020 · 4 comments · Fixed by #5542
Closed

Reordering tabs still crashes when running elevated #5564

DJackman123 opened this issue Apr 25, 2020 · 4 comments · Fixed by #5542
Assignees
@DHowett-MSFT
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Crash Crashes are real bad news.
Milestone
Terminal v1.0

Comments

@DJackman123
Copy link
Contributor

Environment

Windows build number: 10.0.19041.0
Windows Terminal version: 0.11.1133.0

Any other software?

Steps to reproduce

Launch Windows Terminal as administrator. Create a couple of tabs. Use the mouse to click and drag one of the tabs.

Expected behavior

Nothing should happen

Actual behavior

Windows Terminal crashes

#4874 was supposed to prevent tab reordering while elevated and it either doesn't work (can't remember if I tested this when it first released) or some later change broke it again.
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Apr 25, 2020
@Sandra2001
Copy link

My Windows terminal does not crash.
Your @Sandra2001

@DJackman123
Copy link
Contributor Author

Just to double-check: you are running Terminal as administrator, correct?

@DHowett-MSFT
Copy link
Contributor

Sorry about that. We regressed this in an error handling cleanup pass. Fix is in #5542.

@DHowett-MSFT DHowett-MSFT mentioned this issue Apr 25, 2020
Merged
@ghost ghost added the In-PR This issue has a related PR label Apr 25, 2020
@DHowett-MSFT DHowett-MSFT added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Severity-Crash Crashes are real bad news. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Apr 25, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Apr 25, 2020
@DHowett-MSFT DHowett-MSFT self-assigned this Apr 25, 2020
@DHowett-MSFT DHowett-MSFT added this to the Terminal v1.0 milestone Apr 25, 2020
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Apr 27, 2020
DHowett-MSFT pushed a commit that referenced this issue Apr 27, 2020
@DHowett
Actually check the elevation status when disabling tab rearrange (#5542)
8004223 
Fixes #5564.
@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Apr 27, 2020
DHowett-MSFT pushed a commit that referenced this issue Apr 27, 2020
@DHowett
Actually check the elevation status when disabling tab rearrange (#5542)
58876dc 
Fixes #5564.
@ghost
Copy link

ghost commented Apr 28, 2020

🎉This issue was addressed in #5542, which has now been successfully released as Windows Terminal Preview v0.11.1191.0.:tada:

Handy links:

This was referenced Jul 13, 2020
Closed
Closed
@ghost ghost mentioned this issue Nov 6, 2020
Closed
@zadjii-msft zadjii-msft mentioned this issue Nov 4, 2021
Closed
@zadjii-msft zadjii-msft mentioned this issue Jan 3, 2022
Closed
@zadjii-msft zadjii-msft mentioned this issue Aug 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DHowett-MSFT DHowett-MSFT

Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Crash Crashes are real bad news.
Projects
None yet
Milestone
Terminal v1.0
Development

Successfully merging a pull request may close this issue.

Actually check the elevation status when disabling tab rearrange microsoft/terminal
3 participants
@DHowett-MSFT @DJackman123 @Sandra2001