Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal crashes when WSL tab tries to display some characters. #4145

Closed
MichaelWalsh opened this issue Jan 7, 2020 · 5 comments · Fixed by #4150
Closed

Terminal crashes when WSL tab tries to display some characters. #4145

MichaelWalsh opened this issue Jan 7, 2020 · 5 comments · Fixed by #4150
Labels
Area-TerminalConnection Issues pertaining to the terminal<->backend connection interface Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Crash Crashes are real bad news.
Milestone
Terminal v0.9

Comments

@MichaelWalsh
Copy link

Terminal (0.7.3451.0) crashes every time I try to cat or curl a html file containing a certain tweet. The entire terminal frame hangs, white out, goes to (Not Responding).
This happens only with the WSL Ubuntu tab and not when I try to cat the same file with powershell in Terminal. It does not crash with WSL under the older 'Ubuntu' launcher from the Windows Store.

Environment

Windows 10 Pro 1909
Win32NT 10.0.18363.0 Microsoft Windows NT 10.0.18363.0

Windows Terminal (Preview) Version: 0.7.3451.0 from the Windows Store
Ubuntu 18.04.3 LTS installed from the Windows Store

Steps to reproduce

WSL Ubuntu from the Windows Store installed, Terminal from Windows Store installed
Launch Windows Terminal
Window chrome down arrow: Ubuntu

curl 'https://twitter.com/EU_Commission/status/1213399676201734146' -H 'User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:71.0) Gecko/20100101 Firefox/71.0'

curl starts to display the html from that url, but doesn't complete as the whole window frame hangs at some point during the output

Expected behavior

I expected the whole output from curl to be displayed, and return to the bash prompt

Actual behavior

curl starts displaying html output, but then the whole app frame including all tabs becomes unresponsive.

Although Windows displayed the "sending data to Microsoft" from the crash, I don't have a link to share as this computer has no Microsoft Account associated with it, and the feedback tool appears to require one to view crash data.
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jan 7, 2020
@zadjii-msft
Copy link
Member

Well yep, that's a pretty easy repro.

I had to change the command to include https, but yea it happens every time.

curl 'https://twitter.com/EU_Commission/status/1213399676201734146' -H 'User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:71.0) Gecko/20100101 Firefox/71.0'

Unfortunately, just cat'ing the file doesn't repro this.

@zadjii-msft zadjii-msft added Area-TerminalConnection Issues pertaining to the terminal<->backend connection interface Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Severity-Crash Crashes are real bad news. labels Jan 8, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jan 8, 2020
@zadjii-msft zadjii-msft added this to the Terminal-2001 milestone Jan 8, 2020
@lhecker lhecker mentioned this issue Jan 8, 2020
Merged
5 tasks
@ghost ghost added In-PR This issue has a related PR and removed In-PR This issue has a related PR labels Jan 8, 2020
@DHowett-MSFT
Copy link
Contributor

Thanks for the report! This is, largely, a /dupe of #1360.

@ghost
Copy link

ghost commented Jan 9, 2020

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Jan 9, 2020
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. In-PR This issue has a related PR and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jan 9, 2020
ghost pushed a commit that referenced this issue Jan 15, 2020
@lhecker
Fixed a deadlock when printing surrogate pairs (#4150)
3e6b4b5 
## Summary of the Pull Request

See [my code comment](#4150 (comment)) below for technical details of the issue that caused #4145.

## PR Checklist
* [x] Closes #1360, Closes #4145.
* [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA
* [ ] Tests added/passed
* [ ] Requires documentation to be updated
* [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

## Detailed Description of the Pull Request / Additional comments

TBH I kinda hope this project could migrate to an internal use of UTF-8 in the future. 😶

## Validation Steps Performed

Followed the "Steps to reproduce" in #4145 and ensured the "Expected behavior" happens.
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Jan 15, 2020
@j4james j4james mentioned this issue Jan 23, 2020
Closed
DHowett-MSFT pushed a commit that referenced this issue Jan 24, 2020
@lhecker @DHowett
Fixed a deadlock when printing surrogate pairs (#4150)
3b53014 
## Summary of the Pull Request

See [my code comment](#4150 (comment)) below for technical details of the issue that caused #4145.

## PR Checklist
* [x] Closes #1360, Closes #4145.
* [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA
* [ ] Tests added/passed
* [ ] Requires documentation to be updated
* [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

## Detailed Description of the Pull Request / Additional comments

TBH I kinda hope this project could migrate to an internal use of UTF-8 in the future. 😶

## Validation Steps Performed

Followed the "Steps to reproduce" in #4145 and ensured the "Expected behavior" happens.

(cherry picked from commit 3e6b4b5)
@ghost
Copy link

ghost commented Jan 27, 2020

🎉This issue was addressed in #4150, which has now been successfully released as Windows Terminal Preview v0.8.10261.0.:tada:

Handy links:

@ghost
Copy link

ghost commented Feb 13, 2020

🎉This issue was addressed in #4150, which has now been successfully released as Windows Terminal Preview v0.9.433.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-TerminalConnection Issues pertaining to the terminal<->backend connection interface Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Crash Crashes are real bad news.
Projects
None yet
Milestone
Terminal v0.9
Development

Successfully merging a pull request may close this issue.

Fixed a deadlock when printing surrogate pairs
3 participants
@MichaelWalsh @DHowett-MSFT @zadjii-msft