Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-line emoji crashes program #3739

Closed
VikingScientist opened this issue Nov 27, 2019 · 9 comments
Closed

Multi-line emoji crashes program #3739

VikingScientist opened this issue Nov 27, 2019 · 9 comments
Labels
Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. Severity-Crash Crashes are real bad news.

Comments

@VikingScientist
Copy link

Environment

Windows build number: 10.0.18362 Build 18362
Windows Terminal version (if applicable):  0.7.3291.0


Any other software?

Steps to reproduce

Open a new WSL terminal and fill a commandline with emojis (i.e. copy-paste from https://getemoji.com/ ). Resize the terminal window (width) so emojis would need to change line, i.e. the newline character would move location.

Expected behavior

Program would not crash

Actual behavior

Program crashes. "WindowsTerminal.exe is not responding, would you like to close the program".

NOTE: It does not appear with all emojis, but the string " 🤯 😬 😰 😱 🥵 🥶 😳 🤯 😬 😰 😱 🥵 🥶 😳 🤯 😬 😰 😱 🥵 🥶 😳 🤯 😬 😰 😱 🥵 🥶 😳 🤯 😬 😰 😱 🥵 🥶 😳 🤯 😬 😰 😱 🥵 🥶 😳 🤯 😬 😰 😱 🥵 🥶 😳 🤯 😬 😰 😱 🥵 🥶 😳 🤯 😬 😰 😱 🥵 🥶 😳 🤯 😬 😰 😱 🥵 🥶 😳 🤯 😬 😰 😱 🥵 🥶 😳 🤯 😬 😰 😱 🥵 🥶 😳 🤯 😬 😰 😱 🥵 🥶 😳" does cause a crash

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Nov 27, 2019
@VikingScientist VikingScientist changed the title Multi-line emoji crashes WLT Multi-line emoji crashes program Nov 27, 2019
@0xd4d
Copy link

0xd4d commented Nov 27, 2019

Smaller repro, open WSL in WT, paste one of these lines

  • 🥶🥶🥶🥶🥶🥶🥶🥶🥶🥶🥶🥶🥶🥶🥶🥶🥶🥶🥶🥶🥶🥶🥶🥶🥶🥶🥶🥶🥶🥶🥶🥶🥶🥶🥶🥶🥶🥶🥶🥶🥶🥶🥶🥶🥶🥶🥶🥶🥶🥶🥶
  • 🥵🥵🥵🥵🥵🥵🥵🥵🥵🥵🥵🥵🥵🥵🥵🥵🥵🥵🥵🥵🥵🥵🥵🥵🥵🥵🥵🥵🥵🥵🥵🥵🥵🥵🥵🥵🥵🥵🥵🥵🥵🥵🥵🥵🥵🥵🥵🥵🥵🥵🥵
    "initialCols": 120,
    "initialRows": 30,

@zadjii-msft
Copy link
Member

I have a feeling that this is #1360, which will be solved by #780, but just to make sure it is in fact the same thing, could you file a crash report?

/feedback

@ghost
Copy link

ghost commented Nov 27, 2019

Hi there!

Can you please send us feedback with the Feedback Hub with this issue and paste the link here so we can more easily find your crash information on the back end?

Thanks!

image image

@ghost ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Nov 27, 2019
@zadjii-msft zadjii-msft added Product-Terminal The new Windows Terminal. Severity-Crash Crashes are real bad news. labels Nov 27, 2019
@VikingScientist
Copy link
Author

I am unsure on where to find the Feedback Hub and thought #3739 was the crash report. If I press the "Feedback" button inside Windows Terminal, then I get sent directly to the github issue page.

I do not build from source, so I don't know where any debug information gets logged/printed.

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Nov 27, 2019
@zadjii-msft
Copy link
Member

You need to use the "feedback hub" application:
image

If you file a problem using the Feedback hub, and tag it as Apps > Windows Terminal, then hit the "share my feedback" button, you'll get an aka.ms link that we can use to look up the stack trace of the crash on our end.

@zadjii-msft zadjii-msft added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Attention The core contributors need to come back around and look at this ASAP. labels Nov 27, 2019
@VikingScientist
Copy link
Author

This app is blocked by company policy on my computer. I could see if I could try and recreate the entire setup on a different personal computer, but at this point I think it is easier if others try to recreate the bug as I don't think it should be too hard to reproduce.

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Nov 28, 2019
@ts252
Copy link

ts252 commented Nov 28, 2019

Having had similar problems and found my way here, I've reported this via the feedback hub. I don't know how to get an aka.ms link from it but I referenced this github issue in my feedback.

For me it's an "unresponsive" not a crash per se. The tab you paste into freezes immediately, but other tabs are fine until you re-select the frozen one.

@DHowett-MSFT
Copy link
Contributor

Got this under a debugger -- looks the same as /dup #1360

@ghost
Copy link

ghost commented Nov 30, 2019

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Nov 30, 2019
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements Needs-Attention The core contributors need to come back around and look at this ASAP. labels Nov 30, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. Severity-Crash Crashes are real bad news.
Projects
None yet
Development

No branches or pull requests

4 participants