Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tab bar doesn't grow when you resize the window, it only shrinks #3300

Closed
DHowett-MSFT opened this issue Oct 23, 2019 · 16 comments · Fixed by #4024
Closed

Tab bar doesn't grow when you resize the window, it only shrinks #3300

DHowett-MSFT opened this issue Oct 23, 2019 · 16 comments · Fixed by #4024
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Tracking-External This bug isn't resolved, but it's following an external workitem.
Milestone
Terminal v0.8

Comments

@DHowett-MSFT
Copy link
Contributor

Open a number of tabs. Make the window narrower. Make it wider again.

It looks like this:

image
@DHowett-MSFT DHowett-MSFT added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-User Interface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. labels Oct 23, 2019
@DHowett-MSFT DHowett-MSFT added this to the Terminal-1911 milestone Oct 23, 2019
@DHowett-MSFT DHowett-MSFT self-assigned this Oct 23, 2019
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Oct 23, 2019
@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Oct 23, 2019
@DHowett-MSFT DHowett-MSFT pinned this issue Oct 23, 2019
@encladeus encladeus mentioned this issue Oct 24, 2019
Closed
@biltongza
Copy link

Adding a new tab makes the tabs pop back to correct size for me.

@DHowett-MSFT DHowett-MSFT mentioned this issue Oct 24, 2019
Closed
29 tasks
@beviu beviu mentioned this issue Oct 27, 2019
Closed
5 tasks
@ghost ghost added the In-PR This issue has a related PR label Oct 27, 2019
@DHowett-MSFT DHowett-MSFT mentioned this issue Nov 8, 2019
Closed
@ghost
Copy link

ghost commented Nov 9, 2019

How come that it's so difficult for UWP apps to ship a fast and decent UI, while other apps mostly always get it right?

@mdtauk
Copy link

mdtauk commented Nov 9, 2019

How come that it's so difficult for UWP apps to ship a fast and decent UI, while other apps mostly always get it right?

It's because this is a Hybrid app, part UWP, part Win32 - that these kinds of resize and rendering bugs are more likely to happen.

@ghost
Copy link

ghost commented Nov 9, 2019 •
edited by ghost
Loading

How come that it's so difficult for UWP apps to ship a fast and decent UI, while other apps mostly always get it right?

It's because this is a Hybrid app, part UWP, part Win32 - that these kinds of resize and rendering bugs are more likely to happen.

Of course the solution would be to make it entirely UWP.

Except that I've never seen a UWP app that was actually great to use with keyboard and mouse on a desktop computer. They all feel like a crummy annoying mobile app.

Btw: the terminal also looks huge (and there is no way to rescale it to sane levels), it's slow (why is maximizing the app window slower and laggier than in other apps?), startup is slower (it does not show up instantly like other apps even on a fast ssd computer).

And of course, the default font looks like comic sans.

@zadjii-msft zadjii-msft mentioned this issue Nov 11, 2019
Closed
@DHowett-MSFT DHowett-MSFT mentioned this issue Nov 14, 2019
Closed
@warmachinesocial
Copy link

@DHowett-MSFT there would be an arrow the for resizing it but its in the position like of backslash and then pull it upwards.

@warmachinesocial
Copy link

warmachinesocial commented Nov 19, 2019 •
edited
Loading

Also do I file a bug that is try out add multiple tabs like 10 not on maximized screen but normal window size. Then resize the window and maximize it you would notice the size that a maximized window should offer for the tab bar becomes small

@DHowett-MSFT
Copy link
Contributor Author

Please do not file that bug. That is this bug. This is that bug.

@zadjii-msft
Copy link
Member

(this may or may not be the upstream microsoft/microsoft-ui-xaml#1581 - it's unclear at the moment)

@zadjii-msft zadjii-msft mentioned this issue Nov 21, 2019
Closed
@JushBJJ
Copy link

JushBJJ commented Nov 27, 2019

4DVgmK4tLY
Is this relevant? Or should this be in a another issue?
Terminal Version: 0.7.3291.0

@DHowett-MSFT
Copy link
Contributor Author

On account of it being literally the same issue, I’d say it belongs here. :)

@K1ngjulien
Copy link

Do we know by now if this is an issue with ui xaml?

@zadjii-msft
Copy link
Member

@K1ngjulien with the long holiday weekend, I don't think anyone's had a chance to investigate quite yet

@K1ngjulien
Copy link

oh sorry I forgot about that, non american here :D

@mkitzan mkitzan mentioned this issue Dec 6, 2019
Closed
@ghost ghost removed the In-PR This issue has a related PR label Dec 10, 2019
@zadjii-msft
Copy link
Member

So, I'm happy to announce that this was fixed by the upstream microsoft/microsoft-ui-xaml#1744. It might be a bit before we can ingest the latest build of WinUI, but the fix will be coming soon! Thanks again @teaP!

@zadjii-msft zadjii-msft added the Tracking-External This bug isn't resolved, but it's following an external workitem. label Dec 11, 2019
@mkitzan mkitzan mentioned this issue Dec 14, 2019
Closed
@zadjii-msft zadjii-msft mentioned this issue Dec 19, 2019
Merged
2 tasks
@ghost ghost added the In-PR This issue has a related PR label Dec 19, 2019
@ghost ghost closed this as completed in #4024 Dec 19, 2019
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Dec 19, 2019
ghost pushed a commit that referenced this issue Dec 19, 2019
@zadjii-msft
update to the latest MUX prerelease (#4024)
ae580e7 
## Summary of the Pull Request

This latest MUX prerelease fixes the issue where the tab row wouldn't expand to fill the width of the window after shrinking the window size.

## PR Checklist
* [x] Closes #3300
* [x] I work here
* [n/a] Tests added/passed
* [n/a] Requires documentation to be updated

## Detailed Description of the Pull Request / Additional comments

Thanks again @teaP for help fixing this

## Validation Steps Performed

Launched the terminal, played with it a bit
@JushBJJ
Copy link

JushBJJ commented Dec 21, 2019 via email

@ghost
Copy link

ghost commented Jan 14, 2020

🎉This issue was addressed in #4024, which has now been successfully released as Windows Terminal Preview v0.8.10091.0.:tada:

Handy links:

@DHowett-MSFT DHowett-MSFT unpinned this issue Jan 14, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Tracking-External This bug isn't resolved, but it's following an external workitem.
Projects
None yet
Milestone
Terminal v0.8
Development

Successfully merging a pull request may close this issue.

Update to the latest MUX prerelease (2.3.191217003) microsoft/terminal
Fix tab row doesn't grow
7 participants
@biltongza @mdtauk @DHowett-MSFT @K1ngjulien @zadjii-msft @warmachinesocial @JushBJJ