Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Font Features is inconsistent #11287

Closed
Nosamdaman opened this issue Sep 20, 2021 · 5 comments · Fixed by #12492
Closed

Font Features is inconsistent #11287

Nosamdaman opened this issue Sep 20, 2021 · 5 comments · Fixed by #12492
Assignees
@PankajBhojwani
Labels
Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.14

Comments

@Nosamdaman
Copy link

Nosamdaman commented Sep 20, 2021 •
edited
Loading

Windows Terminal version (or Windows build number)

10.0.19043.1237, 1.11.2421.0

Other Software

No response

Steps to reproduce

I'm using the Nerd-Font port of FiraCode as my font for Windows Terminal. Using the new Font Features options, I've configured WT to use the alternate zero glyph which replaces the slash in the middle of the character with a dot. There have been a couple instances in which I've launched a terminal only for the zero glyph to have reverted back to the old style, though launching a new terminal does fix the issue.

Here is my settings config:

"font": 
{
  "face": "FiraCode NF",
  "features": 
  {
    "calt": 0,
    "ss04": 1,
    "zero": 1
  },
  "size": 12
},

I think I've found a way to reproduce this. It seems like it happens when you first launch windows terminal from a full restart.
Ignore that last one, it doesn't happen all the time. I can trigger the effect by dragging my window from a display at 100% scaling to one with 125% scaling.

Expected Behavior

The font should display with the correct 0 symbol

Actual Behavior

The zero symbol is incorrect.
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Sep 20, 2021
@zadjii-msft zadjii-msft added the Product-Terminal The new Windows Terminal. label Sep 22, 2021
@Nosamdaman
Copy link
Author

Updated as I think I have a reproduction case now

@Nosamdaman
Copy link
Author

Updated with a better reproduction example

@DHowett
Copy link
Member

DHowett commented Nov 22, 2021

Thanks, this is really helpful. I'm betting that when we added the new version of UpdateFont that took font features, we didn't consistently call it in all scenarios (like DPI change!). /cc @PankajBhojwani

@DHowett DHowett added Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) labels Nov 22, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Nov 22, 2021
@DHowett DHowett added this to the Terminal v1.14 milestone Nov 22, 2021
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Nov 22, 2021
@PankajBhojwani PankajBhojwani mentioned this issue Feb 15, 2022
Merged
@ghost ghost added the In-PR This issue has a related PR label Feb 15, 2022
@PankajBhojwani PankajBhojwani self-assigned this Feb 15, 2022
@ghost ghost closed this as completed in #12492 Feb 16, 2022
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Feb 16, 2022
ghost pushed a commit that referenced this issue Feb 16, 2022
@PankajBhojwani
Fix font axes/features not working on DPI change (#12492)
3b46794 
When the dpi is changed, call `updateFont()` instead of `TriggerFontChange`, this
means that we continue to use the existing font features/axes

Closes #11287
DHowett pushed a commit that referenced this issue Feb 16, 2022
@PankajBhojwani @DHowett
Fix font axes/features not working on DPI change (#12492)
4e6431c 
When the dpi is changed, call `updateFont()` instead of `TriggerFontChange`, this
means that we continue to use the existing font features/axes

Closes #11287

(cherry picked from commit 3b46794)
DHowett pushed a commit that referenced this issue Feb 16, 2022
@PankajBhojwani @DHowett
Fix font axes/features not working on DPI change (#12492)
b8398d8 
When the dpi is changed, call `updateFont()` instead of `TriggerFontChange`, this
means that we continue to use the existing font features/axes

Closes #11287

(cherry picked from commit 3b46794)
@ghost
Copy link

ghost commented Mar 25, 2022

🎉This issue was addressed in #12492, which has now been successfully released as Windows Terminal v1.12.1073.:tada:

Handy links:

@ghost
Copy link

ghost commented Mar 25, 2022

🎉This issue was addressed in #12492, which has now been successfully released as Windows Terminal Preview v1.13.1073.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PankajBhojwani PankajBhojwani

Labels
Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.14
Development

Successfully merging a pull request may close this issue.

Fix font axes/features not working on DPI change microsoft/terminal
4 participants
@DHowett @zadjii-msft @PankajBhojwani @Nosamdaman