Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong size on Quake mode with hetero sized screens #10182

Closed
kazuf3 opened this issue May 25, 2021 · 3 comments · Fixed by #10674
Closed

Wrong size on Quake mode with hetero sized screens #10182

kazuf3 opened this issue May 25, 2021 · 3 comments · Fixed by #10674
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v2.0

Comments

@kazuf3
Copy link

kazuf3 commented May 25, 2021

Windows Terminal version (or Windows build number)

10.0.19042.0 and 1.9.1445.0

Other Software

No response

Steps to reproduce

  • Activate Quake on big screen (4K) with mod4+`
  • Hide it
  • Activate Quake on small screen (FHD) with mod4+`

Expected Behavior

No response

Actual Behavior

Get this (instead of covering upper half of the screen, it only gives the corner part of terminal):
image
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels May 25, 2021
@kazuf3 kazuf3 changed the title Wrong size on Quake mode with hetero screen Wrong size on Quake mode with hetero sized screens May 25, 2021
@kkoziarski
Copy link

There is also incorrect windows size when you move the quake mode window to second monitor using Win+Shift+Right. When you move it to a smaller monitor, the right side is cut off and impossible to scroll right.
image

@zadjii-msft zadjii-msft added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-User Interface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. labels May 26, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label May 26, 2021
@zadjii-msft zadjii-msft added this to the Terminal v2.0 milestone May 26, 2021
@zadjii-msft zadjii-msft mentioned this issue May 26, 2021
Open
61 tasks
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label May 27, 2021
@zadjii-msft zadjii-msft added the Priority-2 A description (P2) label Jul 15, 2021
zadjii-msft added a commit that referenced this issue Jul 15, 2021
@zadjii-msft
Fixes #10274, Fixes #10182
6959b31 
  I can't believe that we never did this. We'd just leave the quake
  window's size totally unchanged. That's so ridiculously dumb.
@zadjii-msft zadjii-msft mentioned this issue Jul 15, 2021
Merged
3 tasks
@ghost ghost added the In-PR This issue has a related PR label Jul 15, 2021
@zadjii-msft zadjii-msft mentioned this issue Jul 19, 2021
Closed
@ghost ghost closed this as completed in #10674 Jul 20, 2021
ghost pushed a commit that referenced this issue Jul 20, 2021
@zadjii-msft
Re-evaluate the size of the quake window when it's summoned to a moni…
9c1331a 
…tor (#10674)

## Summary of the Pull Request

When the quake window is moved to another monitor, re-evaluate it's size for that monitor.

## References
* megathread: #8888
* Similar, but not the same: #10274

## PR Checklist
* [x] Closes #10182
* [x] I work here
* [ ] Tests added/passed
* [n/a] Requires documentation to be updated

## Detailed Description of the Pull Request / Additional comments

We'll probably need to do this in a few more places, but I'm breaking PRs into small chunks for easier reviews.

## Validation Steps Performed

Summoned the window to a bunch of different resolutions. Where it would use the wrong size before, it no longer does.
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Jul 20, 2021
This was referenced Aug 5, 2021
Closed
Closed
DHowett pushed a commit that referenced this issue Aug 25, 2021
@zadjii-msft @DHowett
Re-evaluate the size of the quake window when it's summoned to a moni…
0cd97a9 
…tor (#10674)

## Summary of the Pull Request

When the quake window is moved to another monitor, re-evaluate it's size for that monitor.

## References
* megathread: #8888
* Similar, but not the same: #10274

## PR Checklist
* [x] Closes #10182
* [x] I work here
* [ ] Tests added/passed
* [n/a] Requires documentation to be updated

## Detailed Description of the Pull Request / Additional comments

We'll probably need to do this in a few more places, but I'm breaking PRs into small chunks for easier reviews.

## Validation Steps Performed

Summoned the window to a bunch of different resolutions. Where it would use the wrong size before, it no longer does.
@ghost
Copy link

ghost commented Aug 31, 2021

🎉This issue was addressed in #10674, which has now been successfully released as Windows Terminal Preview v1.10.2383.0.:tada:

Handy links:

@ghost
Copy link

ghost commented Aug 31, 2021

🎉This issue was addressed in #10674, which has now been successfully released as Windows Terminal Preview v1.11.2421.0.:tada:

Handy links:

@zadjii-msft zadjii-msft mentioned this issue Aug 12, 2022
Open
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v2.0
Development

Successfully merging a pull request may close this issue.

Re-evaluate the size of the quake window when it's summoned to a monitor microsoft/terminal
4 participants
@DHowett @kkoziarski @zadjii-msft @kazuf3