-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix the xterm and SGR mouse encodings for CTRL, ALT, SHIFT (#8379)
We had the xterm and SGR codings for meta/ctrl backwards. Oops. This commit also fixes an observed issue in Windows Terminal where we were passing in a console-style modifiers enum when MouseInput is expecting MK_ constants. I decided to unify MouseInput around the console-style modifier constants because they have support for META (which MK_ does not) and can differentiate between left/right alt/ctrl. Our tests are fundamentally flawed here: they use a copy of the modifier key generating logic _themselves_, so we got a bit of "error carried forward." I did not fix the tests to use known-good control sequences, I simply replaced the character generator with another copy of the modifier code. I did, however, extend them to test ctrl|meta and left/right modifiers. Fixes #8291
- Loading branch information
Showing
3 changed files
with
33 additions
and
25 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters