Skip to content

Commit

Permalink
and spacing
Browse files Browse the repository at this point in the history
  • Loading branch information
@DHowett
DHowett committed Apr 29, 2020
1 parent fb373bb commit 851391f
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions build/scripts/Test-WindowsTerminalPackage.ps1
View file
Original file line number Diff line number Diff line change
Expand Up @@ -75,12 +75,12 @@ Try {
$filesHasVclibsAppX = ($null -ne (Get-Item "$AppxPackageRootPath\vcruntime140_app.dll" -EA:Ignore)) -or ($null -ne (Get-Item "$AppxPackageRootPath\vcruntime140d_app.dll" -EA:Ignore))

If ($depsHasVclibsDesktop -and $filesHasVclibsDesktop) {
Throw "Package has Dependency *and* integrated Desktop VCLibs"
Throw "Package has Dependency *and* integrated Desktop VCLibs"
}

If ($depsHasVclibsAppx -and $filesHasVclibsAppx) {
# We've shipped like this forever, so downgrade to warning.
Write-Warning "Package has Dependency *and* integrated AppX VCLibs"
# We've shipped like this forever, so downgrade to warning.
Write-Warning "Package has Dependency *and* integrated AppX VCLibs"
}

### Check that we have an App.xbf (which is a proxy for our resources having been merged)
Expand Down

1 comment on commit 851391f

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New misspellings found, please review:

  • deps
  • vcruntime
To accept these changes, run the following commands 
remove_obsolete_words=$(mktemp)
echo '#!/usr/bin/perl -ni
my $re=join "|", qw('"
Emojis
HREF
textblock
usr
vpack
"');
next if /^($re)(?:$| .*)/;
print;' > $remove_obsolete_words
chmod +x $remove_obsolete_words
for file in .github/actions/spell-check/whitelist/alphabet.txt .github/actions/spell-check/whitelist/web.txt .github/actions/spell-check/whitelist/whitelist.txt; do $remove_obsolete_words $file; done
rm $remove_obsolete_words
(
echo "
deps
href
vcruntime
"
) | sort -u -f | perl -ne 'next unless /./; print' > new_whitelist.txt && mv new_whitelist.txt '.github/actions/spell-check/whitelist/851391f581905922d643cfc960014ac79297e8f7.txt'
✏️ Contributor please read this
  • If the items listed above are names, please add them to .github/actions/spell-check/dictionary/names.txt.
  • If they're APIs, you can add them to a file in .github/actions/spell-check/dictionary/.
  • If they're just things you're using, please add them to an appropriate file in .github/actions/spell-check/whitelist/.
  • If you need to use a specific token in one place and it shouldn't generally be used, you can
    add an item in an appropriate file in .github/actions/spell-check/patterns/.

See the README.md in each directory for more information.

⚠️ Reviewers

At present, the action that triggered this message will not show its ❌ in this PR unless the branch is within this repository.
Thus, you should make sure that this comment has been addressed before encouraging the merge bot to merge this PR.

Please sign in to comment.