-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix a conhost binary size regression due to fmt (#11727)
6140fd9 causes a binary size regression in conhost. This PR fixes most if not all of the regression, by replacing `FMT_STRING` with `FMT_COMPILE` allowing us to drop most of the formatters built into fmt during linking (for instance floating point formatters). Additionally `std::wstring` was replaced with `fmt::basic_memory_buffer` in the same vein as was done for VtEngine. Stack is cheap and this prevents any unnecessary allocations. ## PR Checklist * [x] I work here * [x] Tests added/passed ## Validation Steps Performed * vttest 11.2.5.3.6.7 and .8 (DECSTBM and SGR) complete successfully ✅
- Loading branch information
Showing
1 changed file
with
28 additions
and
24 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters