fix: ensure scripts always have Unix newlines #860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34 tasks
HeyImChris
approved these changes
Oct 21, 2021
acoates-ms
added a commit
that referenced
this pull request
Oct 28, 2021
…ore publish (#866) * Some more changes for bringing up RN64 in devmain Android (#861) * Build & Packaging changes for bringing up RN64 in devmain * Fixing gradle clean * Disable gradle clean in PR builds * Fix for submit button disappearing bug in comments (#862) * Add the missing android folder to files in package.json * Fix for submit button disappear bug in comments Co-authored-by: Mayuresh Gharpure <Mayuresh.Gharpure@microsoft.com> * fix: ensure scripts always have Unix newlines (#860) * Fix for publishing from stable branches * remove workspace info before publishing too * Update rntester lock file when bumping package version * Apply #875 * Allow newer cocoapod version Co-authored-by: Anandraj <anandrag@microsoft.com> Co-authored-by: Mayuresh Gharpure <gharpuremayuresh@gmail.com> Co-authored-by: Mayuresh Gharpure <Mayuresh.Gharpure@microsoft.com> Co-authored-by: Tommy Nguyen <4123478+tido64@users.noreply.github.com>
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
pod installis currently failing on latest canary with an error message:: command not found. This is caused by Windows newlines in shell scripts. The added.gitattributesfile should ensure that they will always be checked out with Unix newlines, even on Windows machines.Fixes #850
Changelog
[General] [Fixed] - Shell scripts fail to execute because they contain Windows newlines.
Test Plan
Check out the branch on a Windows machine and ensure that scripts (e.g.
scripts/ios-configure-glog.sh) don't contain carriage return (\r). Alternatively, verify that Git has the correct attributes set with: