-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[0.72] Merge up to 0.72.6 upstream #1952
Commits on Oct 2, 2023
-
Move hermes-engine.podspec and hermes-utils.rb from hermes-engine to …
…hermes folders when building (facebook#39575)
Configuration menu - View commit details
-
Copy full SHA for 3c4cc59 - Browse repository at this point
Copy the full SHA 3c4cc59View commit details
Commits on Oct 11, 2023
-
Update Xcode 15 patches to be more robust (facebook#39710)
Summary: Pull Request resolved: facebook#39710 Last week Apple released Xcode 15, which required us to ship a workaround for the new linker. Unfortunately, the previous fix was not good enough and there were some edge cases that were not covered. For example, in some occasions the flags are read as an array and the `-Wl` and the `-ld_classic` flags were separated and not properly removed when moving from Xcode 15 to Xcpde 14.3.1. This change fixes those edge cases, with a more robust solution where: - We convert the flags to a string. - We trim the string and the values properly. - We add the flags when running `pod install` with Xcode 15 as the default iOS toolchain. - We remove the flags when running `pod install` with Xcode <15 as the default iOS toolchain. ## Changelog: [Internal] - Make the Xcode 15 workaround more robust. Reviewed By: dmytrorykun Differential Revision: D49748844 fbshipit-source-id: 34976d148f123c5aacba6487a500874bb938fe99 # Conflicts: # packages/react-native/scripts/cocoapods/__tests__/utils-test.rb # packages/react-native/scripts/cocoapods/utils.rb
Configuration menu - View commit details
-
Copy full SHA for 355025d - Browse repository at this point
Copy the full SHA 355025dView commit details -
Fix Gemfile, setting Active support to < 7.1.0 (facebook#39828)
Summary: Pull Request resolved: facebook#39828 Active Suppert released a new Gem which is incompatible with Cocoapods 1.13.0, the latest release, as they removed a method used by cocoapods. This fix ensures that we install compatible versions of the Gem. ## Changelog: [iOS][Fixed] - Set the max version of Active support to 7.0.8 Reviewed By: hoxyq Differential Revision: D49949782 fbshipit-source-id: 278097502d3a416567cc8c0b90090fee4fb21503 # Conflicts: # Gemfile
Configuration menu - View commit details
-
Copy full SHA for 785f91b - Browse repository at this point
Copy the full SHA 785f91bView commit details -
RN: Switch EventEmitter to
Array.from(...)
(facebook#39525)Summary: Pull Request resolved: facebook#39525 Switches `EventEmitter#emit` to use `Array.from` instead of the spread operator. This should be functionally identical (with marginally less overhead of the runtime having to determine the type of `registrations`), but there seems to be [some unexpected Babel configurations in the community](facebook#35577 (comment)) that causes this line of code to do the wrong things. Although we should independently root cause the Babel plugin configuration problems, this change might provide immediate relief and is also not any worse (e.g. in terms of code readability). This also adds a descriptive comment explaining the intention of the call to `Array.from`. Changelog: [Fixed][General] - Fix a potential bug in `EventEmitter` when used with certain Babel configurations that incorrectly polyfill the spread operator for iterables. Reviewed By: javache Differential Revision: D49389813 fbshipit-source-id: 7caf63734fc047496afe2f1ed6d918c22747258a
Configuration menu - View commit details
-
Copy full SHA for 9b3bd63 - Browse repository at this point
Copy the full SHA 9b3bd63View commit details
Commits on Oct 12, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 6e3a130 - Browse repository at this point
Copy the full SHA 6e3a130View commit details -
Distiller committed
Oct 12, 2023 Configuration menu - View commit details
-
Copy full SHA for 4fd3da2 - Browse repository at this point
Copy the full SHA 4fd3da2View commit details -
Bump deprecated-react-native-prop-types to ^4.2.3
This version correctly sets a dependency on `"@react-native/normalize-colors": "<0.73.0"` (from `"*"`), preventing future unwanted breakages.
Configuration menu - View commit details
-
Copy full SHA for e031c05 - Browse repository at this point
Copy the full SHA e031c05View commit details
Commits on Oct 13, 2023
-
Fix broken Loading/Refreshing indicator on Android
Summary: The Loading.../Refreshing... indicator is currently broken on Android. The reason is related to D42599220 We used to have a Toast shown to users on Android as a fallback, but as the DevLoadingView is not always loaded as a module in the core package, this ends up in the banner never beign shown to the user (on RN Tester or template apps). Changelog: [Android] [Fixed] - Fix broken Loading/Refreshing indicator on Android Reviewed By: cipolleschi Differential Revision: D49876757 fbshipit-source-id: 400e002327ebca908e3e7a7f81c5066888ac4e9b
Configuration menu - View commit details
-
Copy full SHA for 3a4d79e - Browse repository at this point
Copy the full SHA 3a4d79eView commit details
Commits on Oct 16, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 6e60a91 - Browse repository at this point
Copy the full SHA 6e60a91View commit details