Don't send events when clicking on scrollbars #1281
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
This will ignore "touches" (clicks) on
NSScroller
such that JS does not process them resulting in a press event.Changelog
[macOS] [Changed] - Don't send events when clicking on scrollbars
Test Plan
Confirmed clicking scrollbar in rn-tester does not result in a click on the items underneath.
Before
Both scrollView scroller and content clicks are processed
before.mov
After
Clicking onto the scrollView scroller > click is ignored
Clicking into the the scrollView > no change of behavior
after.mov