Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android Gradle Plugin 3.x integration #1219

Merged
merged 4 commits into from
Mar 12, 2018
Merged

Android Gradle Plugin 3.x integration #1219

merged 4 commits into from
Mar 12, 2018

Conversation

itoys
Copy link
Contributor

@itoys itoys commented Feb 28, 2018

Includes back compatibility for old RN versions
Resolves #1214

@rexih
Copy link

rexih commented Aug 5, 2019

i'm an android developer, our team need to use code push and i'm studying the codepush.gradle file,
i check the commit said

  • AAPT2-compatible Android build process integration
  • enhancement
  • enhancement
  • fix assembleDebug

it was ambiguous for me,
could you tell me the difference of the two conditional branch :
if (variant.hasProperty("bundleJsAndAssets")) { } else { }
i found if has the property ,only create generateBundledResourcesHash task, if not ,it will create generateBundledResourcesHash and recordFilesBeforeBundleCommand task

why there were two different behavor

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Requiring images with latest gradle fails release builds
2 participants