Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: added run_id to reports and to the ctx object #40

Merged
merged 3 commits into from
Jul 13, 2021

Conversation

cryptaliagy
Copy link
Collaborator

Closes #38

Added run IDs to Quilla to better group and uniquely identify different runs. This is useful for storing all the report summaries to be able to uniquely identify them, and will be even more useful once we start using storage plugins for the VisualParity validation, since then different treatment images can be grouped up by run ID.

Since this is adding a new CLI flag, I also took the time to do a few quality of life changes to the parser:

  • Categorized different parsing options in argument groups to group them more logically
  • Added --indent to specify the indent level of the pretty-printed output
  • Changed the usage string to not display all of the options since there are so many of them

@cryptaliagy cryptaliagy added the enhancement New feature or request label Jul 13, 2021
@cryptaliagy cryptaliagy requested a review from a team July 13, 2021 15:35
@yucui-avengers
Copy link

Any plan to pass in run id in VP plugin definition?

@cryptaliagy
Copy link
Collaborator Author

Any plan to pass in run id in VP plugin definition?

It’s included in the Context object which the VP plugins have access to. This way, it’s something future plug-in developers can use, but it doesn’t instruct them to: they can decide on their own storage mechanism for images.

@cryptaliagy cryptaliagy merged commit 13292d2 into main Jul 13, 2021
@cryptaliagy cryptaliagy deleted the feat/runningIDs branch July 13, 2021 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate "Running IDs" into Quilla
2 participants