Fix recursion issue in pxt-arcade and gridLiteral comment attribute #10072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thsparks
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two small unrelated fixes that I was too lazy to open separately:
gridLiteralcomment attribute so that it is correctly marked as a numeric attribute (just likeimageLiteral)Turns out that
getElementsByTagNamereturns a "live" list, so if more shadow blocks were added by the recursive call it would end up making the length of the array longer so that it looped infinitely. I fixed it by using ourtoArrayutil to convert it into a static list.gridLiteralis used for creating blocks that have the matrix field editor (like the show leds block in pxt-microbit). I need it for the CSP robot extension that I'm working on.