Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: show error when opening newer trace with old viewer #31781

Merged
merged 1 commit into from
Jul 22, 2024
Merged

chore: show error when opening newer trace with old viewer #31781

merged 1 commit into from
Jul 22, 2024

Conversation

yury-s
Copy link
Member

@yury-s yury-s commented Jul 20, 2024

@yury-s yury-s requested review from dgozman and mxschmitt July 20, 2024 01:41
@github-actions GitHub Actions
Copy link
Contributor

Test results for "tests 1"

5 flaky ⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [firefox-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [webkit-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture

23946 passed, 616 skipped
✔️✔️✔️

Merge workflow run.

@yury-s yury-s merged commit bef8784 into microsoft:main Jul 22, 2024
26 of 30 checks passed
@yury-s yury-s deleted the new-trace-version branch July 22, 2024 15:16
yury-s added a commit to yury-s/playwright that referenced this pull request Jul 22, 2024
@yury-s
cherry-pick(microsoft#31781): chore: show error when opening newer tr…
26d7143 
…ace with old viewer

Reference: microsoft/playwright-java#1617
yury-s added a commit that referenced this pull request Jul 22, 2024
@yury-s
cherry-pick(#31781): chore: show error when opening newer trace with … (
2f17a27 
#31797)

…old viewer

Reference: microsoft/playwright-java#1617
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgozman dgozman dgozman approved these changes

@mxschmitt mxschmitt Awaiting requested review from mxschmitt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yury-s @dgozman