-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): add host option in launchServer options #30999
Conversation
@microsoft-github-policy-service agree |
afbc5bd
to
9577643
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % comments
5ae09b1
to
d7d5785
Compare
This comment has been minimized.
This comment has been minimized.
@mxschmitt Is this dirty error caused by me pushing twice quickly? |
This comment has been minimized.
This comment has been minimized.
You need to run npm run build, it will then update some generated files. |
BTW, I found that although the ws server pointed out that the ws url was https://nodejs.org/api/net.html#serverlistenport-host-backlog-callback To fix it, we need to do either of these things:
|
This comment has been minimized.
This comment has been minimized.
63e9e16
to
6dc063e
Compare
This comment has been minimized.
This comment has been minimized.
Finally, I followed this to keep compatibility, what do you think? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Test results for "tests 1"2 flaky27061 passed, 609 skipped Merge workflow run. |
Closes 30998.