Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix 'exposeFunction should not leak' in video mode #28169

Merged
merged 1 commit into from
Nov 15, 2023
Merged

test: fix 'exposeFunction should not leak' in video mode #28169

merged 1 commit into from
Nov 15, 2023

Conversation

mxschmitt
Copy link
Member

@mxschmitt mxschmitt commented Nov 15, 2023 •
edited
Loading

This is like how we do it with the other channel tests. In video mode we produce artifacts so we need to add them to our expectation.

@github-actions GitHub Actions
Copy link
Contributor

Test results for "tests 1"

1 flaky ⚠️ [playwright-test] › ui-mode-test-progress.spec.ts:165:5 › should update tracing network live

26143 passed, 612 skipped
✔️✔️✔️

Merge workflow run.

yury-s
yury-s approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@yury-s yury-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a description why it fixes the issue?

@mxschmitt mxschmitt merged commit 7ffcb42 into microsoft:main Nov 15, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yury-s yury-s yury-s approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mxschmitt @yury-s