Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(logs): Add new log level to capture client-server message's metadata information #28141

Merged
merged 4 commits into from
Nov 15, 2023

Conversation

Sid200026
Copy link
Member

Goal - Capture minimal diagnostic information for each message being sent between the playwright client and server.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

Test results for "tests 1"

2 failed
❌ [playwright-test] › playwright.artifacts.spec.ts:306:5 › should work with trace: on-all-retries
❌ [playwright-test] › test-step.spec.ts:255:5 › should not report nested after hooks

6 flaky ⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [firefox] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [playwright-test] › ui-mode-test-screencast.spec.ts:21:5 › should show screenshots
⚠️ [webkit] › page/page-goto.spec.ts:277:3 › should fail when navigating to bad SSL after redirects

26136 passed, 612 skipped
✔️✔️✔️

Merge workflow run.

@dgozman dgozman merged commit 4575c9a into microsoft:main Nov 15, 2023
28 of 30 checks passed
@Sid200026 Sid200026 deleted the chore/add-server-metadata-log-level branch November 16, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants