Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: apply only filtration to deps #24268

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Conversation

pavelfeldman
Copy link
Member

No description provided.

@github-actions
Copy link
Contributor

Test results for "tests 1"

1 failed
❌ [playwright-test-macos-latest-node16] › ui-mode-trace.spec.ts:53:5 › should merge web assertion events

6 flaky
⚠️ [playwright-test-macos-latest-node16] › ui-mode-trace.spec.ts:126:5 › should show snapshots for sync assertions
⚠️ [firefox-ubuntu-22.04-node16] › library/tracing.spec.ts:706:5 › should not emit after w/o before
⚠️ [firefox-ubuntu-22.04-node16] › page/page-goto.spec.ts:471:3 › should succeed on url bar navigation when there is pending navigation
⚠️ [webkit-ubuntu-22.04-node16] › library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker
⚠️ [webkit-ubuntu-22.04-node16] › library/inspector/cli-codegen-javascript.spec.ts:87:5 › should save the codegen output to a file if specified
⚠️ [chromium-ubuntu-22.04-node20] › library/tracing.spec.ts:239:5 › should not include trace resources from the provious chunks

21682 passed, 509 skipped
✔️✔️✔️

[playwright-test-macos-latest-node16] › ui-mode-trace.spec.ts:53:5 › should merge web assertion events

Error: action list

- Expected  -  6
+ Received  + 10

  Array [
-   /Before Hooks[\d.]+m?s/,
-   /page.setContent[\d.]+m?s/,
-   /expect.toBeVisiblelocator\('button'\)[\d.]+m?s/,
-   /After Hooks[\d.]+m?s/,
-   /fixture: page[\d.]+m?s/,
-   /fixture: context[\d.]+m?s/,
+   "Before Hooks1.1s",
+   "fixture: browser556ms",
+   "fixture: context45ms",
+   "fixture: page478ms",
+   "browserContext.newPage442ms",
+   "page.setContent26ms",
+   "expect.toBeVisiblelocator('button')34ms",
+   "After Hooks1ms",
+   "fixture: page0ms",
+   "fixture: context0ms",
  ]
Call log:
  - expect.toHaveText with timeout 75000ms
  - waiting for getByTestId('action-list').getByRole('listitem')
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 1 element
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements


  68 |       listItem,
  69 |       'action list'
> 70 |   ).toHaveText([
     |     ^
  71 |     /Before Hooks[\d.]+m?s/,
  72 |     /page.setContent[\d.]+m?s/,
  73 |     /expect.toBeVisiblelocator\('button'\)[\d.]+m?s/,

    at /Users/runner/work/playwright/playwright/tests/playwright-test/ui-mode-trace.spec.ts:70:5

Retry 1:

Error: action list

- Expected  -  6
+ Received  + 10

  Array [
-   /Before Hooks[\d.]+m?s/,
-   /page.setContent[\d.]+m?s/,
-   /expect.toBeVisiblelocator\('button'\)[\d.]+m?s/,
-   /After Hooks[\d.]+m?s/,
-   /fixture: page[\d.]+m?s/,
-   /fixture: context[\d.]+m?s/,
+   "Before Hooks1.1s",
+   "fixture: browser624ms",
+   "fixture: context41ms",
+   "fixture: page336ms",
+   "browserContext.newPage319ms",
+   "page.setContent23ms",
+   "expect.toBeVisiblelocator('button')34ms",
+   "After Hooks2ms",
+   "fixture: page0ms",
+   "fixture: context0ms",
  ]
Call log:
  - expect.toHaveText with timeout 75000ms
  - waiting for getByTestId('action-list').getByRole('listitem')
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements


  68 |       listItem,
  69 |       'action list'
> 70 |   ).toHaveText([
     |     ^
  71 |     /Before Hooks[\d.]+m?s/,
  72 |     /page.setContent[\d.]+m?s/,
  73 |     /expect.toBeVisiblelocator\('button'\)[\d.]+m?s/,

    at /Users/runner/work/playwright/playwright/tests/playwright-test/ui-mode-trace.spec.ts:70:5

Retry 2:

Error: action list

- Expected  -  6
+ Received  + 10

  Array [
-   /Before Hooks[\d.]+m?s/,
-   /page.setContent[\d.]+m?s/,
-   /expect.toBeVisiblelocator\('button'\)[\d.]+m?s/,
-   /After Hooks[\d.]+m?s/,
-   /fixture: page[\d.]+m?s/,
-   /fixture: context[\d.]+m?s/,
+   "Before Hooks985ms",
+   "fixture: browser623ms",
+   "fixture: context56ms",
+   "fixture: page252ms",
+   "browserContext.newPage239ms",
+   "page.setContent26ms",
+   "expect.toBeVisiblelocator('button')31ms",
+   "After Hooks2ms",
+   "fixture: page0ms",
+   "fixture: context0ms",
  ]
Call log:
  - expect.toHaveText with timeout 75000ms
  - waiting for getByTestId('action-list').getByRole('listitem')
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements


  68 |       listItem,
  69 |       'action list'
> 70 |   ).toHaveText([
     |     ^
  71 |     /Before Hooks[\d.]+m?s/,
  72 |     /page.setContent[\d.]+m?s/,
  73 |     /expect.toBeVisiblelocator\('button'\)[\d.]+m?s/,

    at /Users/runner/work/playwright/playwright/tests/playwright-test/ui-mode-trace.spec.ts:70:5

Retry 3:

Error: action list

- Expected  -  6
+ Received  + 10

  Array [
-   /Before Hooks[\d.]+m?s/,
-   /page.setContent[\d.]+m?s/,
-   /expect.toBeVisiblelocator\('button'\)[\d.]+m?s/,
-   /After Hooks[\d.]+m?s/,
-   /fixture: page[\d.]+m?s/,
-   /fixture: context[\d.]+m?s/,
+   "Before Hooks906ms",
+   "fixture: browser609ms",
+   "fixture: context43ms",
+   "fixture: page209ms",
+   "browserContext.newPage196ms",
+   "page.setContent60ms",
+   "expect.toBeVisiblelocator('button')31ms",
+   "After Hooks2ms",
+   "fixture: page0ms",
+   "fixture: context0ms",
  ]
Call log:
  - expect.toHaveText with timeout 75000ms
  - waiting for getByTestId('action-list').getByRole('listitem')
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements


  68 |       listItem,
  69 |       'action list'
> 70 |   ).toHaveText([
     |     ^
  71 |     /Before Hooks[\d.]+m?s/,
  72 |     /page.setContent[\d.]+m?s/,
  73 |     /expect.toBeVisiblelocator\('button'\)[\d.]+m?s/,

    at /Users/runner/work/playwright/playwright/tests/playwright-test/ui-mode-trace.spec.ts:70:5

⚠️ [playwright-test-macos-latest-node16] › ui-mode-trace.spec.ts:126:5 › should show snapshots for sync assertions

Error: action list

- Expected  -  7
+ Received  + 11

  Array [
-   /Before Hooks[\d.]+m?s/,
-   /page\.setContent[\d.]+m?s/,
-   /locator\.clickgetByRole\('button'\)[\d.]+m?s/,
-   /expect\.toBe[\d.]+m?s/,
-   /After Hooks[\d.]+m?s/,
-   /fixture: page[\d.]+m?s/,
-   /fixture: context[\d.]+m?s/,
+   "Before Hooks850ms",
+   "fixture: browser579ms",
+   "fixture: context47ms",
+   "fixture: page176ms",
+   "browserContext.newPage158ms",
+   "page.setContent56ms",
+   "locator.clickgetByRole('button')295ms",
+   "expect.toBe1ms",
+   "After Hooks2ms",
+   "fixture: page0ms",
+   "fixture: context0ms",
  ]
Call log:
  - expect.toHaveText with timeout 75000ms
  - waiting for getByTestId('action-list').getByRole('listitem')
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements


  142 |       listItem,
  143 |       'action list'
> 144 |   ).toHaveText([
      |     ^
  145 |     /Before Hooks[\d.]+m?s/,
  146 |     /page\.setContent[\d.]+m?s/,
  147 |     /locator\.clickgetByRole\('button'\)[\d.]+m?s/,

    at /Users/runner/work/playwright/playwright/tests/playwright-test/ui-mode-trace.spec.ts:144:5

Retry 1:

Error: action list

- Expected  -  7
+ Received  + 11

  Array [
-   /Before Hooks[\d.]+m?s/,
-   /page\.setContent[\d.]+m?s/,
-   /locator\.clickgetByRole\('button'\)[\d.]+m?s/,
-   /expect\.toBe[\d.]+m?s/,
-   /After Hooks[\d.]+m?s/,
-   /fixture: page[\d.]+m?s/,
-   /fixture: context[\d.]+m?s/,
+   "Before Hooks966ms",
+   "fixture: browser595ms",
+   "fixture: context40ms",
+   "fixture: page282ms",
+   "browserContext.newPage264ms",
+   "page.setContent34ms",
+   "locator.clickgetByRole('button')182ms",
+   "expect.toBe1ms",
+   "After Hooks2ms",
+   "fixture: page0ms",
+   "fixture: context0ms",
  ]
Call log:
  - expect.toHaveText with timeout 75000ms
  - waiting for getByTestId('action-list').getByRole('listitem')
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements


  142 |       listItem,
  143 |       'action list'
> 144 |   ).toHaveText([
      |     ^
  145 |     /Before Hooks[\d.]+m?s/,
  146 |     /page\.setContent[\d.]+m?s/,
  147 |     /locator\.clickgetByRole\('button'\)[\d.]+m?s/,

    at /Users/runner/work/playwright/playwright/tests/playwright-test/ui-mode-trace.spec.ts:144:5

Retry 2:

Error: action list

- Expected  -  7
+ Received  + 11

  Array [
-   /Before Hooks[\d.]+m?s/,
-   /page\.setContent[\d.]+m?s/,
-   /locator\.clickgetByRole\('button'\)[\d.]+m?s/,
-   /expect\.toBe[\d.]+m?s/,
-   /After Hooks[\d.]+m?s/,
-   /fixture: page[\d.]+m?s/,
-   /fixture: context[\d.]+m?s/,
+   "Before Hooks881ms",
+   "fixture: browser542ms",
+   "fixture: context42ms",
+   "fixture: page250ms",
+   "browserContext.newPage241ms",
+   "page.setContent58ms",
+   "locator.clickgetByRole('button')153ms",
+   "expect.toBe1ms",
+   "After Hooks2ms",
+   "fixture: page0ms",
+   "fixture: context0ms",
  ]
Call log:
  - expect.toHaveText with timeout 75000ms
  - waiting for getByTestId('action-list').getByRole('listitem')
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements
  -   locator resolved to 11 elements


  142 |       listItem,
  143 |       'action list'
> 144 |   ).toHaveText([
      |     ^
  145 |     /Before Hooks[\d.]+m?s/,
  146 |     /page\.setContent[\d.]+m?s/,
  147 |     /locator\.clickgetByRole\('button'\)[\d.]+m?s/,

    at /Users/runner/work/playwright/playwright/tests/playwright-test/ui-mode-trace.spec.ts:144:5

⚠️ [firefox-ubuntu-22.04-node16] › library/tracing.spec.ts:706:5 › should not emit after w/o before

Error: expect(received).toEqual(expected) // deep equality

- Expected  -  1
+ Received  + 11

  Array [
    Object {
+     "apiName": "page.evaluate",
+     "callId": Any<Number>,
+     "type": "before",
+   },
+   Object {
      "apiName": "page.evaluateHandle",
      "callId": Any<Number>,
      "type": "before",
    },
    Object {
      "apiName": undefined,
-     "callId": Any<Number>,
+     "callId": 0,
+     "type": "after",
+   },
+   Object {
+     "apiName": undefined,
+     "callId": 8,
      "type": "after",
    },
  ]

  753 |   {
  754 |     const { events } = await parseTraceRaw(testInfo.outputPath('trace2.zip'));
> 755 |     expect(events.map(sanitize).filter(Boolean)).toEqual([
      |                                                  ^
  756 |       {
  757 |         type: 'before',
  758 |         callId: expect.any(Number),

    at /home/runner/work/playwright/playwright/tests/library/tracing.spec.ts:755:50

⚠️ [firefox-ubuntu-22.04-node16] › page/page-goto.spec.ts:471:3 › should succeed on url bar navigation when there is pending navigation

Error: expect(received).toEqual(expected) // deep equality

- Expected  - 1
+ Received  + 1

  Array [
    "started c",
-   "started b",
    "finished c",
+   "started b",
    "finished b",
  ]

Call Log:
- Timeout 5000ms exceeded while waiting on the predicate

  502 |   const error = await page.goto(server.PREFIX + '/b').then(r => null, e => e);
  503 |   const expectEvents = ['started c', 'started b', 'finished c', 'finished b'];
> 504 |   await expect(() => expect(events).toEqual(expectEvents)).toPass({ timeout: 5000 });
      |                                                            ^
  505 |   expect(events).toEqual(expectEvents);
  506 |   expect(error).toBeFalsy();
  507 |   expect(page.url()).toBe(server.PREFIX + '/b');

    at /home/runner/work/playwright/playwright/tests/page/page-goto.spec.ts:504:60

⚠️ [webkit-ubuntu-22.04-node16] › library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker

Test timeout of 30000ms exceeded.

⚠️ [webkit-ubuntu-22.04-node16] › library/inspector/cli-codegen-javascript.spec.ts:87:5 › should save the codegen output to a file if specified

Error: Process failed with exit code 1

   at config/commonFixtures.ts:202

  200 |     const r = await this.exited;
  201 |     if (r.exitCode)
> 202 |       throw new Error(`Process failed with exit code ${r.exitCode}`);
      |             ^
  203 |     if (r.signal)
  204 |       throw new Error(`Process received signal: ${r.signal}`);
  205 |   }

    at TestChildProcess.cleanExit (/home/runner/work/playwright/playwright/tests/config/commonFixtures.ts:202:13)
    at /home/runner/work/playwright/playwright/tests/config/baseTest.ts:49:14
    at /home/runner/work/playwright/playwright/tests/library/inspector/cli-codegen-javascript.spec.ts:92:3

Retry 1:

Error: Process failed with exit code 1

   at config/commonFixtures.ts:202

  200 |     const r = await this.exited;
  201 |     if (r.exitCode)
> 202 |       throw new Error(`Process failed with exit code ${r.exitCode}`);
      |             ^
  203 |     if (r.signal)
  204 |       throw new Error(`Process received signal: ${r.signal}`);
  205 |   }

    at TestChildProcess.cleanExit (/home/runner/work/playwright/playwright/tests/config/commonFixtures.ts:202:13)
    at /home/runner/work/playwright/playwright/tests/config/baseTest.ts:49:14
    at /home/runner/work/playwright/playwright/tests/library/inspector/cli-codegen-javascript.spec.ts:92:3

⚠️ [chromium-ubuntu-22.04-node20] › library/tracing.spec.ts:239:5 › should not include trace resources from the provious chunks

Error: expect(received).toBe(expected) // Object.is equality

Expected: 0
Received: 1

  266 |     // 1 network resource should be preserved.
  267 |     expect(names.filter(n => n.endsWith('.html')).length).toBe(1);
> 268 |     expect(names.filter(n => n.endsWith('.jpeg')).length).toBe(0);
      |                                                           ^
  269 |     // 0 source file for the second test.
  270 |     expect(names.filter(n => n.endsWith('.txt')).length).toBe(0);
  271 |   }

    at /home/runner/work/playwright/playwright/tests/library/tracing.spec.ts:268:59
--- Merge [workflow run](https://github.com/microsoft/playwright/actions/runs/5581153549).

@pavelfeldman pavelfeldman merged commit 5ff1fad into microsoft:main Jul 17, 2023
26 of 27 checks passed
@github-actions
Copy link
Contributor

Test results for "tests 1"

1 failed
❌ [firefox-ubuntu-22.04-node16] › library/tracing.spec.ts:706:5 › should not emit after w/o before

4 flaky
⚠️ [chromium-ubuntu-22.04-node18] › page/page-event-request.spec.ts💯3 › should report navigation requests and responses handled by service worker
⚠️ [chromium-ubuntu-22.04-node16] › library/capabilities.spec.ts:137:3 › should not crash on showDirectoryPicker
⚠️ [chromium-ubuntu-22.04-node20] › page/page-event-request.spec.ts:129:3 › should report navigation requests and responses handled by service worker with routing
⚠️ [webkit-ubuntu-22.04-node16] › library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker

21684 passed, 509 skipped
✔️✔️✔️

[firefox-ubuntu-22.04-node16] › library/tracing.spec.ts:706:5 › should not emit after w/o before

Error: expect(received).toEqual(expected) // deep equality

- Expected  -  1
+ Received  + 11

  Array [
    Object {
+     "apiName": "page.evaluate",
+     "callId": Any<Number>,
+     "type": "before",
+   },
+   Object {
      "apiName": "page.evaluateHandle",
      "callId": Any<Number>,
      "type": "before",
    },
    Object {
      "apiName": undefined,
-     "callId": Any<Number>,
+     "callId": 0,
+     "type": "after",
+   },
+   Object {
+     "apiName": undefined,
+     "callId": 8,
      "type": "after",
    },
  ]

  753 |   {
  754 |     const { events } = await parseTraceRaw(testInfo.outputPath('trace2.zip'));
> 755 |     expect(events.map(sanitize).filter(Boolean)).toEqual([
      |                                                  ^
  756 |       {
  757 |         type: 'before',
  758 |         callId: expect.any(Number),

    at /home/runner/work/playwright/playwright/tests/library/tracing.spec.ts:755:50

Retry 1:

Error: expect(received).toEqual(expected) // deep equality

- Expected  -  1
+ Received  + 11

  Array [
    Object {
+     "apiName": "page.evaluate",
+     "callId": Any<Number>,
+     "type": "before",
+   },
+   Object {
      "apiName": "page.evaluateHandle",
      "callId": Any<Number>,
      "type": "before",
    },
    Object {
      "apiName": undefined,
-     "callId": Any<Number>,
+     "callId": 0,
+     "type": "after",
+   },
+   Object {
+     "apiName": undefined,
+     "callId": 6,
      "type": "after",
    },
  ]

  753 |   {
  754 |     const { events } = await parseTraceRaw(testInfo.outputPath('trace2.zip'));
> 755 |     expect(events.map(sanitize).filter(Boolean)).toEqual([
      |                                                  ^
  756 |       {
  757 |         type: 'before',
  758 |         callId: expect.any(Number),

    at /home/runner/work/playwright/playwright/tests/library/tracing.spec.ts:755:50

Retry 2:

Error: expect(received).toEqual(expected) // deep equality

- Expected  -  1
+ Received  + 11

  Array [
    Object {
+     "apiName": "page.evaluate",
+     "callId": Any<Number>,
+     "type": "before",
+   },
+   Object {
      "apiName": "page.evaluateHandle",
      "callId": Any<Number>,
      "type": "before",
    },
    Object {
      "apiName": undefined,
-     "callId": Any<Number>,
+     "callId": 0,
+     "type": "after",
+   },
+   Object {
+     "apiName": undefined,
+     "callId": 6,
      "type": "after",
    },
  ]

  753 |   {
  754 |     const { events } = await parseTraceRaw(testInfo.outputPath('trace2.zip'));
> 755 |     expect(events.map(sanitize).filter(Boolean)).toEqual([
      |                                                  ^
  756 |       {
  757 |         type: 'before',
  758 |         callId: expect.any(Number),

    at /home/runner/work/playwright/playwright/tests/library/tracing.spec.ts:755:50

Retry 3:

Error: expect(received).toEqual(expected) // deep equality

- Expected  -  1
+ Received  + 11

  Array [
    Object {
+     "apiName": "page.evaluate",
+     "callId": Any<Number>,
+     "type": "before",
+   },
+   Object {
      "apiName": "page.evaluateHandle",
      "callId": Any<Number>,
      "type": "before",
    },
    Object {
      "apiName": undefined,
-     "callId": Any<Number>,
+     "callId": 0,
+     "type": "after",
+   },
+   Object {
+     "apiName": undefined,
+     "callId": 6,
      "type": "after",
    },
  ]

  753 |   {
  754 |     const { events } = await parseTraceRaw(testInfo.outputPath('trace2.zip'));
> 755 |     expect(events.map(sanitize).filter(Boolean)).toEqual([
      |                                                  ^
  756 |       {
  757 |         type: 'before',
  758 |         callId: expect.any(Number),

    at /home/runner/work/playwright/playwright/tests/library/tracing.spec.ts:755:50
--- Merge [workflow run](https://github.com/microsoft/playwright/actions/runs/5581929472).

@sosullivanIDBS
Copy link

sosullivanIDBS commented Aug 15, 2023

Hello! This has caused a bug where test.only no longer works if a project has dependencies.

When I use test.only and run npx playwright test, I get the following error:

TypeError: Cannot read properties of undefined (reading '_hasTests')

I would suggest a fix, but it would ultimately be to back out this change. I'm not sure what the original purpose of this change was? It is a change in behaviour that tries to exclude dependencies when a test has test.only?

@mxschmitt
Copy link
Member

Do you mind filing a bug for this? We usually don't monitor closed issues / PRs, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants