Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: some actions do not appear in the trace file #31764

Closed
DetachHead opened this issue Jul 19, 2024 · 1 comment · Fixed by #31768
Closed

[Bug]: some actions do not appear in the trace file #31764

DetachHead opened this issue Jul 19, 2024 · 1 comment · Fixed by #31768
Assignees
@dgozman
Labels
v1.46

Comments

@DetachHead
Copy link
Contributor

Version

1.45.2

Steps to reproduce

  1. clone https://github.com/DetachHead/playwright-bug
  2. run npm ci
  3. run node index.js
  4. run playwright show-trace asdf.zip

Expected behavior

all four locator actions appear in the trace file

Actual behavior

only the last 2 actions appear:

image

Additional context

No response

Environment

System:
    OS: Windows 11 10.0.22621
    CPU: (12) x64 11th Gen Intel(R) Core(TM) i5-11500H @ 2.90GHz
    Memory: 9.70 GB / 31.20 GB
  Binaries:
    Node: 19.7.0 - ~\AppData\Roaming\node\node.EXE
    npm: 9.5.0 - ~\AppData\Roaming\node\npm.CMD
  IDEs:
    VSCode: 1.91.1 - C:\Users\user\AppData\Local\Programs\Microsoft VS Code\bin\code.CMD
  npmPackages:
    playwright: ^1.45.2 => 1.45.2
@DetachHead
Copy link
Contributor Author

DetachHead commented Jul 19, 2024 •
edited
Loading

this bug seems to have been introduced in 1.45.0. as far as i can tell it appears that actions with the same function name as a previous action are overwriting the previous one

@dgozman dgozman self-assigned this Jul 19, 2024
@dgozman dgozman added the v1.46 label Jul 19, 2024
This was referenced Jul 19, 2024
Merged
Closed
dgozman added a commit that referenced this issue Jul 19, 2024
@dgozman
fix(trace viewer): library-only trace should not merge actions (#31768)
b535139 
Without `wallTime`, actions are matched by `actionName:undefined` and
all actions with the same are merged.

Fixes #31764.
yury-s pushed a commit to yury-s/playwright that referenced this issue Jul 20, 2024
@dgozman @yury-s
cherry-pick(microsoft#31768): fix(trace viewer): library-only trace s…
c44e4a1 
…hould not merge actions

Without `wallTime`, actions are matched by `actionName:undefined` and
all actions with the same are merged.

Fixes microsoft#31764.
yury-s pushed a commit to yury-s/playwright that referenced this issue Jul 22, 2024
@dgozman @yury-s
cherry-pick(microsoft#31768): fix(trace viewer): library-only trace s…
8b976f4 
…hould not merge actions

Without `wallTime`, actions are matched by `actionName:undefined` and
all actions with the same are merged.

Fixes microsoft#31764.
szinn pushed a commit to szinn/wordacle that referenced this issue Jul 23, 2024
@repo-jeeves
chore(deps): update dependency @playwright/test to v1.45.3 (#83)
2072e4b 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@playwright/test](https://playwright.dev)
([source](https://togithub.com/microsoft/playwright)) | devDependencies
| patch | [`1.45.2` ->
`1.45.3`](https://renovatebot.com/diffs/npm/@playwright%2ftest/1.45.2/1.45.3)
|

---

### Release Notes

<details>
<summary>microsoft/playwright (@&#8203;playwright/test)</summary>

###
[`v1.45.3`](https://togithub.com/microsoft/playwright/releases/tag/v1.45.3)

[Compare
Source](https://togithub.com/microsoft/playwright/compare/v1.45.2...v1.45.3)

##### Highlights


[microsoft/playwright#31764
- \[Bug]: some actions do not appear in the trace
file[microsoft/playwright-java#1617
- \[Bug]: Traceviewer not reporting all actions

#### Browser Versions

-   Chromium 127.0.6533.5
-   Mozilla Firefox 127.0
-   WebKit 17.4

This version was also tested against the following stable channels:

-   Google Chrome 126
-   Microsoft Edge 126

</details>

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuMCIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJ0eXBlL3BhdGNoIl19-->

Co-authored-by: repo-jeeves[bot] <106431701+repo-jeeves[bot]@users.noreply.github.com>
This was referenced Aug 12, 2024
Open
Open
This was referenced Aug 12, 2024
Open
Open
Open
This was referenced Aug 13, 2024
Open
Open
@drobinso drobinso mentioned this issue Aug 13, 2024
Open
@ARUMAIS ARUMAIS mentioned this issue Aug 13, 2024
Open
@snyk-io snyk-io bot mentioned this issue Aug 14, 2024
Open
@ARUMAIS ARUMAIS mentioned this issue Aug 15, 2024
Open
@browseman browseman mentioned this issue Aug 15, 2024
Closed
This was referenced Aug 16, 2024
Open
Open
Open
Open
Open
@ramzimalhas ramzimalhas mentioned this issue Aug 22, 2024
Open
This was referenced Aug 22, 2024
Open
Open
@snyk-io snyk-io bot mentioned this issue Aug 31, 2024
Open
This was referenced Sep 1, 2024
Open
Open
Open
Open
Open
Open
This was referenced Sep 7, 2024
Open
Open
@ARUMAIS ARUMAIS mentioned this issue Sep 7, 2024
Open
This was referenced Sep 7, 2024
Open
Open
@ARUMAIS ARUMAIS mentioned this issue Sep 8, 2024
Open
@leonardoadame leonardoadame mentioned this issue Sep 9, 2024
Open
@ARUMAIS ARUMAIS mentioned this issue Sep 9, 2024
Open
@WontonSam WontonSam mentioned this issue Sep 9, 2024
Open
@leonardoadame leonardoadame mentioned this issue Sep 10, 2024
Open
This was referenced Sep 10, 2024
Open
Open
@leonardoadame leonardoadame mentioned this issue Sep 11, 2024
Open
@black-da-bull black-da-bull mentioned this issue Sep 12, 2024
Open
@ARUMAIS ARUMAIS mentioned this issue Sep 12, 2024
Open
@WontonSam WontonSam mentioned this issue Sep 12, 2024
Open
@leonardoadame leonardoadame mentioned this issue Sep 12, 2024
Open
@ARUMAIS ARUMAIS mentioned this issue Sep 13, 2024
Open
This was referenced Sep 13, 2024
Open
Open
Open
This was referenced Sep 14, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgozman dgozman

Labels
v1.46
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(trace viewer): library-only trace should not merge actions dgozman/playwright
2 participants
@dgozman @DetachHead