Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: delete not-exposed test-retries implementation #2928

Merged
merged 2 commits into from
May 1, 2024

Conversation

mxschmitt
Copy link
Member

@mxschmitt mxschmitt commented May 1, 2024

This was never public, we used retries on our internal tests only.

So lets either re-add it for only our internal tests only (because before it was half public half internal) or stick with NUnit defaults: e.g. https://docs.nunit.org/articles/nunit/writing-tests/attributes/retry.html.

@mxschmitt mxschmitt force-pushed the chore/remove-unused-test-retries-implementation branch from b2f842a to 9fc33e2 Compare May 1, 2024 13:47
@mxschmitt mxschmitt marked this pull request as ready for review May 1, 2024 16:56
Copy link
Member

@yury-s yury-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So lets either re-add it for only our internal tests only (because before it was half public half internal) or stick with NUnit defaults:

If you want to keep it then let's just change the implementation so that it's private?

@mxschmitt
Copy link
Member Author

So lets either re-add it for only our internal tests only (because before it was half public half internal) or stick with NUnit defaults:

If you want to keep it then let's just change the implementation so that it's private?

I'd try to live without for now - maybe revisit it in the future.

@mxschmitt mxschmitt merged commit 5d489a9 into main May 1, 2024
13 of 15 checks passed
@mxschmitt mxschmitt deleted the chore/remove-unused-test-retries-implementation branch May 1, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants