chore: get rid of build warnings (#2824)

microsoft · Jan 17, 2024 · e964457 · e964457
1 parent a6c75af
commit e964457
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 10 deletions.
diff --git a/src/Common/Dependencies.props b/src/Common/Dependencies.props
@@ -18,7 +18,7 @@
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
       <PrivateAssets>all</PrivateAssets>
     </PackageReference>
-    <PackageReference Include="Microsoft.CodeAnalysis.NetAnalyzers" Version="7.0.3">
+    <PackageReference Include="Microsoft.CodeAnalysis.NetAnalyzers" Version="8.0.0">
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
     </PackageReference>

diff --git a/src/Playwright.Tests/BrowserContextRouteTests.cs b/src/Playwright.Tests/BrowserContextRouteTests.cs
@@ -88,11 +88,11 @@ await context.RouteAsync("**/empty.html", (route) =>
             route.ContinueAsync();
         });
 
-        Action<IRoute> handler4 = (route) =>
+        void handler4(IRoute route)
         {
             intercepted.Add(4);
             route.ContinueAsync();
-        };
+        }
         await context.RouteAsync(new Regex("/empty.html"), handler4);
 
         await page.GotoAsync(Server.EmptyPage);
@@ -125,11 +125,11 @@ await page.RouteAsync("/empty.html", (route) =>
             route.ContinueAsync();
         });
 
-        Action<IRoute> handler2 = (route) =>
+        void handler2(IRoute route)
         {
             intercepted.Add(2);
             route.ContinueAsync();
-        };
+        }
         await page.RouteAsync("/empty.html", handler2);
 
         await page.GotoAsync(Server.EmptyPage);
@@ -363,7 +363,7 @@ public async Task ShouldWorkIfHandlerWithTimesParameterWasRemovedFromAnotherHand
         await using var context = await Browser.NewContextAsync();
         var page = await context.NewPageAsync();
         var intercepted = new List<string>();
-        async Task handler(IRoute route)
+        void handler(IRoute route)
         {
             intercepted.Add("first");
             route.ContinueAsync();

diff --git a/src/Playwright.Tests/PageRouteTests.cs b/src/Playwright.Tests/PageRouteTests.cs
@@ -81,11 +81,11 @@ await Page.RouteAsync("**/empty.html", (route) =>
         });
 
 
-        Action<IRoute> handler4 = (route) =>
+        void handler4(IRoute route)
         {
             intercepted.Add(4);
             route.FallbackAsync();
-        };
+        }
 
         await Page.RouteAsync(new Regex("/empty.html"), handler4);
         await Page.GotoAsync(Server.EmptyPage);
@@ -771,7 +771,7 @@ await page.RouteAsync("**/empty.html", (route) =>
     public async Task ShouldWorkIfHandlerWithTimesParameterWasRemovedFromAnotherHandler()
     {
         var intercepted = new List<string>();
-        async Task handler(IRoute route)
+        void handler(IRoute route)
         {
             intercepted.Add("first");
             route.ContinueAsync();

diff --git a/src/Playwright/Core/Locator.cs b/src/Playwright/Core/Locator.cs
@@ -26,6 +26,7 @@
 using System;
 using System.Collections.Generic;
 using System.Diagnostics;
+using System.Globalization;
 using System.Linq;
 using System.Text.Encodings.Web;
 using System.Text.Json;
@@ -534,7 +535,7 @@ internal static string GetByRoleSelector(AriaRole role, ByRoleOptions options)
         }
         if (options.Level != null)
         {
-            props.Add(new List<string> { "level", options.Level.ToString() });
+            props.Add(new List<string> { "level", options.Level?.ToString(CultureInfo.InvariantCulture) });
         }
         if (options.Name != null)
         {