Skip to content
This repository has been archived by the owner on Jun 6, 2024. It is now read-only.

Add an internal storage barrier to postgresql #5343

Merged
merged 1 commit into from
Mar 4, 2021

Conversation

hzy46
Copy link
Contributor

@hzy46 hzy46 commented Mar 3, 2021

to fix #5341

@hzy46 hzy46 requested a review from Binyang2014 March 3, 2021 04:05
@hzy46 hzy46 changed the title Add a internal storage barrier to postgresql Add an internal storage barrier to postgresql Mar 3, 2021
@coveralls
Copy link

Coverage Status

Coverage remained the same at 34.07% when pulling 900380c on zhiyuhe/fix_master_db_bug into d9b3d7d on master.

Copy link
Contributor

@Binyang2014 Binyang2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not move internal storage into postgresql folder. If it only used by postgresql

@hzy46
Copy link
Contributor Author

hzy46 commented Mar 3, 2021

Why not move internal storage into postgresql folder. If it only used by postgresql

For current usage, there's no difference between putting it in postgresql and internal-storage.

But if there are other services relying on internal-storage, putting this in internal-storage can make it easier to reuse. It may happen in the future.

Copy link
Contributor

@Binyang2014 Binyang2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ok for me as a hot-fix. Please create another issue to move to to postgresql. Then we can make the code much more clean and leverage the k8s mechanism.

@hzy46
Copy link
Contributor Author

hzy46 commented Mar 3, 2021

It's ok for me as a hot-fix. Please create another issue to move to to postgresql. Then we can make the code much more clean and leverage the k8s mechanism.

I have record the new design to #5344 . It does have some advantages. However, considering there's only one service using internal storage now, it may be not worth the effort to implement the new mechanism. We can leave it to a future work.

@hzy46 hzy46 merged commit 86a0924 into master Mar 4, 2021
@hzy46 hzy46 deleted the zhiyuhe/fix_master_db_bug branch March 4, 2021 07:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Database may use unmounted host path
3 participants