[DML EP] Fix external data unpacking #19415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdwr
previously approved these changes
Feb 6, 2024
onnxruntime/core/providers/dml/DmlExecutionProvider/src/MLOperatorAuthorImpl.h
Show resolved
Hide resolved
jeffbloo
reviewed
Feb 6, 2024
onnxruntime/core/providers/dml/DmlExecutionProvider/src/MLOperatorAuthorImpl.cpp
Show resolved
Hide resolved
jeffbloo
approved these changes
Feb 6, 2024
fdwr
reviewed
Feb 7, 2024
|
|
||
| if (constantInput && tensorDesc->totalTensorSizeInBytes < c_maxConstNodeDataSize) | ||
| if (tensorDesc->totalTensorSizeInBytes < c_maxConstNodeDataSize) |
There was a problem hiding this comment.
Shouldn't this be <=? I presume c_maxConstNodeDataSize is inclusive.
YUNQIUGUO
pushed a commit
that referenced
this pull request
Feb 8, 2024
### Description This change 55a6694 didn't take into account external data when unpacking initializer, and therefore crashes when trying to unpack them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change 55a6694 didn't take into account external data when unpacking initializer, and therefore crashes when trying to unpack them.