Fix Split index bugs uncovered by QNN SDK 2.19 #19381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianlizarraga
commented
Feb 2, 2024
adrianlizarraga
commented
Feb 2, 2024
adrianlizarraga
changed the title
jywu-msft
approved these changes
Feb 2, 2024
YUNQIUGUO
pushed a commit
that referenced
this pull request
Feb 8, 2024
### Description - When converting ONNX split sizes to QNN split indices, do not include the split at index 0. QNN 2.19 assumes index 0 is implicit and throws a validation error if provided. - Fix bug when using an ONNX Split operator with a `num_outputs` attribute that does not evenly divide into `shape[axis]`. The ONNX spec states that the last chunk should be smaller, but QNN EP made the last chunk larger. - Fix bug when using an ONNX Split operator with a `split` input. QNN EP was incorrectly passing the split sizes as split indices without conversion. ### Motivation and Context QNN SDK 2.19 updated validation criteria for Split operators. QNN EP was previously passing a split index that should have been implicit. Also, discovered a bugs when using `num_outputs` attribute and `split` input.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
num_outputsattribute that does not evenly divide intoshape[axis]. The ONNX spec states that the last chunk should be smaller, but QNN EP made the last chunk larger.splitinput. QNN EP was incorrectly passing the split sizes as split indices without conversion.Motivation and Context
QNN SDK 2.19 updated validation criteria for Split operators. QNN EP was previously passing a split index that should have been implicit.
Also, discovered a bugs when using
num_outputsattribute andsplitinput.