[Quant tool] Ensure MSFT opset for Q/DQ models #19335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianlizarraga
changed the title
![github-advanced-security[bot]](https://github.com/avatars/in/57789?s=60&v=4){kind=small}
| if extra_options and extra_options.get("UseQDQContribOps", False): | ||
| qdq_model = onnx.load_model(model_qdq_path) | ||
| ms_opset = next((opset for opset in qdq_model.opset_import if opset.domain == "com.microsoft"), None) | ||
| self.assertTrue(ms_opset is not None) |
Check notice
Code scanning / CodeQL
Imprecise assert Note
jywu-msft
approved these changes
Jan 30, 2024
yufenglee
approved these changes
Jan 30, 2024
YUNQIUGUO
pushed a commit
that referenced
this pull request
Feb 8, 2024
### Description Updates qdq quantization to ensure the final model has the `com.microsoft` opset import if the model uses Q/DQ ops with the `com.microsoft` domain (e.g., for int16 quantization) ### Motivation and Context Need to ensure the MSFT domain is correctly set for all relevant cases. Otherwise, shape inferencing tools will raise an exception.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates qdq quantization to ensure the final model has the
com.microsoftopset import if the model uses Q/DQ ops with thecom.microsoftdomain (e.g., for int16 quantization)Motivation and Context
Need to ensure the MSFT domain is correctly set for all relevant cases. Otherwise, shape inferencing tools will raise an exception.