[TensorRT EP] Fix memory leak for cudnn/cublas #18467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jywu-msft
approved these changes
Nov 16, 2023
jywu-msft
pushed a commit
that referenced
this pull request
Nov 17, 2023
Free memory for cudnn/cublas instances at TRT EP destruction. #18466
| @@ -1194,6 +1194,11 @@ TensorrtExecutionProvider::~TensorrtExecutionProvider() { | |||
| } | |||
| } | |||
|
|
|||
| if (external_stream_) { | |||
| ORT_IGNORE_RETURN_VALUE(CUBLAS_CALL(cublasDestroy(external_cublas_handle_))); | |||
There was a problem hiding this comment.
Can we store these in class member unique_ptrs (with custom deleter) at the time of creation so that we don't have to remember to destroy them? It looks like this code is repeated in both ~PerThreadContext and ~TensorrtExecutionProvider.
The same applies to this part of the code.
hgaiser
pushed a commit
to robohouse-delft/onnxruntime
that referenced
this pull request
Nov 23, 2023
Cherry-pick the following PRs: microsoft#18467 microsoft#17797 microsoft#18341 microsoft#18456
kleiti
pushed a commit
to kleiti/onnxruntime
that referenced
this pull request
Mar 22, 2024
Free memory for cudnn/cublas instances at TRT EP destruction. microsoft#18466
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Free memory for cudnn/cublas instances at TRT EP destruction.
#18466