Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug that accidentally disabled training op tests #16488

Merged
merged 3 commits into from
Jun 28, 2023
Merged

Fix bug that accidentally disabled training op tests #16488

merged 3 commits into from
Jun 28, 2023

Conversation

baijumeswani
Copy link
Contributor

A recent pull request #16326 accidentally disabled the training op tests from being run in the training pipeline.

This pull request fixes that.

Thanks @pengwa @PeixuanZuo for reporting the problem. Sorry for the inconvenience.

@baijumeswani baijumeswani added training issues related to ONNX Runtime training; typically submitted using template build build issues; typically submitted using template labels Jun 27, 2023
@baijumeswani baijumeswani reopened this Jun 27, 2023
pengwa
pengwa approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@pengwa pengwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the tests run now.

2023-06-27T18:17:42.1001595Z 1: [----------] 4 tests from PadAndUnflattenTest
2023-06-27T18:17:42.1001922Z 1: [ RUN ] PadAndUnflattenTest.FloatType1D
2023-06-27T18:17:42.1002561Z 1: 2023-06-27 18:17:42.099740932 [W:onnxruntime:Default, base_tester.cc:763 ExecuteModelForEps] registered execution providers CPUExecutionProvider were unable to run the model.
2023-06-27T18:17:42.1034317Z 1: [ OK ] PadAndUnflattenTest.FloatType1D (3 ms)
2023-06-27T18:17:42.1034928Z 1: [ RUN ] PadAndUnflattenTest.FloatType2D
2023-06-27T18:17:42.1035710Z 1: 2023-06-27 18:17:42.103221641 [W:onnxruntime:Default, base_tester.cc:763 ExecuteModelForEps] registered execution providers CPUExecutionProvider were unable to run the model.
2023-06-27T18:17:42.1068306Z 1: [ OK ] PadAndUnflattenTest.FloatType2D (3 ms)
2023-06-27T18:17:42.1068745Z 1: [ RUN ] PadAndUnflattenTest.MLFloat16Type1D
2023-06-27T18:17:42.1069956Z 1: 2023-06-27 18:17:42.106670451 [W:onnxruntime:Default, base_tester.cc:763 ExecuteModelForEps] registered execution providers CPUExecutionProvider were unable to run the model.
2023-06-27T18:17:42.1104736Z 1: [ OK ] PadAndUnflattenTest.MLFloat16Type1D (3 ms)
2023-06-27T18:17:42.1105176Z 1: [ RUN ] PadAndUnflattenTest.MLFloat16Type2D
2023-06-27T18:17:42.1105865Z 1: 2023-06-27 18:17:42.110302056 [W:onnxruntime:Default, base_tester.cc:763 ExecuteModelForEps] registered execution providers CPUExecutionProvider were unable to run the model.
2023-06-27T18:17:42.1142108Z 1: [ OK ] PadAndUnflattenTest.MLFloat16Type2D (3 ms)
2023-06-27T18:17:42.1142901Z 1: [----------] 4 tests from PadAndUnflattenTest (14 ms total)

@baijumeswani baijumeswani merged commit cbfbe21 into main Jun 28, 2023
89 of 91 checks passed
@baijumeswani baijumeswani deleted the baijumeswani/bug-fix branch June 28, 2023 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pengwa pengwa pengwa approved these changes

@askhade askhade Awaiting requested review from askhade

@PeixuanZuo PeixuanZuo Awaiting requested review from PeixuanZuo

Assignees
No one assigned
Labels
build build issues; typically submitted using template training issues related to ONNX Runtime training; typically submitted using template
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baijumeswani @pengwa