[DML EP] Enable all datatypes for Abs and Sign #13470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatriceVignola
changed the title
fdwr
reviewed
Oct 26, 2022
onnxruntime/core/providers/dml/DmlExecutionProvider/src/Operators/OperatorRegistration.cpp
Outdated
Show resolved
Hide resolved
fdwr
approved these changes
Oct 27, 2022
PatriceVignola
deleted the
user/pavignol/enable-abs-sign-all-datatypes
branch
linnealovespie
pushed a commit
that referenced
this pull request
Oct 28, 2022
### Description Enables all datatypes supported for DML for `Abs` and `Sign`. ### Motivation and Context `Abs` and `Sign` haven't been updated since DML started to support all datatypes for them. These ops are used in some transformer models and were forcing unnecessary copies between the CPU and the GPU.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enables all datatypes supported for DML for
AbsandSign.Motivation and Context
AbsandSignhaven't been updated since DML started to support all datatypes for them. These ops are used in some transformer models and were forcing unnecessary copies between the CPU and the GPU.