Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DML EP Fix InstanceNormalization with 3D tensors #12693

Merged
merged 3 commits into from
Aug 24, 2022

Conversation

fdwr
Copy link
Contributor

@fdwr fdwr commented Aug 23, 2022

Description: The DML EP previously only accepted NCHW (4D) for InstanceNormalization. This fixes the case where 3D tensors are passed (NCH), which would yield:

D3D12 ERROR: Mismatched tensor sizes. Tensor 'Input' has size of 1 in dimension 1, while tensor 'Scale' has size of 32 in dimension 1.
Both tensors are expected to have the same sizes in all dimensions. [ UNKNOWN ERROR #1: STRING_FROM_APPLICATION]
S:\WindowsAI\dml\SharedValidation/TensorValidator.h(439)\DirectML.Debug.dll!00007FF90212DE9B: (caller: 00007FF90211B969) Exception(1) tid(9af4) 80070057 The parameter is incorrect.
    [TensorValidator::ValidateIsBroadcastCompatibleWithFirst(E_INVALIDARG)]

Motivation and Context

@fdwr fdwr requested a review from sumitsays August 23, 2022 23:25
sumitsays
sumitsays previously approved these changes Aug 24, 2022
@fdwr fdwr merged commit 3f47119 into main Aug 24, 2022
@fdwr fdwr deleted the user/dwayner/FixInstanceNormalizationWhen3D branch August 24, 2022 21:58
smk2007 pushed a commit that referenced this pull request Sep 7, 2022
Fix InstanceNormalization with 3D tensors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants