Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry for release 1.12.0 final #12218

Merged
merged 15 commits into from
Jul 19, 2022
Merged

Cherry for release 1.12.0 final #12218

merged 15 commits into from
Jul 19, 2022

Conversation

RandySheriffH
Copy link
Contributor

@RandySheriffH RandySheriffH commented Jul 18, 2022

Merge tagged commits to release 1.12.0.
Note that commits from PR are included since another PR depends on them.

zhijxu-MS and others added 15 commits July 18, 2022 13:03
* fp16_optimizer for more ds versions

* change ds version

* bugfix

* fix bug
Changed from static function defined in header to function declared in header and defined in separate .cc file.
Co-authored-by: Ashwini Khade <askhade@microsoft.com@orttrainingdev10.d32nl1ml4oruzj4qz3bqlggovf.px.internal.cloudapp.net>
* RoiAlign add warning about incorrect max summation when sample size not 1
#12138)

include coreml_provider_factory.h in macos build instead of coreml_execution_provider.h
list 3.10 as supported python version and remove 3.6

Co-authored-by: Randy Shuai <rashuai@microsoft.com>
Co-authored-by: Jingyan Wang, Baiju Meswani
…ute (#12158)

* Fix GH issue 12151.

Need to use inverse perms for updating that axis to what is used for transposing the input. This only applies if the DQ node is doing per-axis dequantization.
* fixing positions for beam search gpt2
Co-authored-by: Tianlei Wu <tlwu@microsoft.com>
* Add file mapping for windows platform.

* Add unit test for file mapping for windows. Also add an error message for mis-aligned offset

* Add unit test for file mapping for windows. Also add an error message for mis-aligned offset

* Update data type to avoid warnings

* Compitable data type to avoid warnings. Update CreatFileMapping2 condition for winml compiling.

* Add type conversion to avoid warnings for X86 release build.

Co-authored-by: Ting Cao <ticao@microsoft.com>
Fix bug where onnxruntime_USE_NCCL flag would default to ON, causing ORT to not build properly. New functionality: flag is ON when training is enabled and NCCL is not disabled. Flag is OFF otherwise
Copy link
Contributor

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@lgtm-com
Copy link

lgtm-com bot commented Jul 18, 2022

This pull request introduces 25 alerts and fixes 1 when merging 45b8e11 into 62226d0 - view on LGTM.com

new alerts:

  • 24 for Commented-out code
  • 1 for Unused import

fixed alerts:

  • 1 for Unused import

@RandySheriffH RandySheriffH self-assigned this Jul 18, 2022
@RandySheriffH RandySheriffH merged commit 0d4f0f8 into rel-1.12.0 Jul 19, 2022
@RandySheriffH RandySheriffH deleted the cherry-1.12.0-r2 branch July 19, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.