support optimizer opt for deepspeed 0.5.9 #11949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pengwa
reviewed
Jun 22, 2022
| @@ -141,6 +141,10 @@ def has_overflow_partitioned_grads_serial(target): | |||
| #### END OF THE ORIGINAL IMPLEMENTATION #### | |||
|
|
|||
| #### THIS IS THE FASTER IMPLEMENTATION #### | |||
| import deepspeed | |||
|
|
|||
| if deepspeed.__version__ >= "0.5.7": | |||
There was a problem hiding this comment.
nit: better use same way check the version.
v > LooseVersion("0.5.9")
There was a problem hiding this comment.
good point!
fixed
|
Do you have a rough perf number having this override? Maybe you can add some details in the PR description, which could be helpful for users who want to use it. |
pengwa
approved these changes
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.