Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT]: resume waiting/running, dedup on tuner side (TPE-only) #4931

Merged
merged 2 commits into from
Aug 10, 2022
Merged

[FEAT]: resume waiting/running, dedup on tuner side (TPE-only) #4931

merged 2 commits into from
Aug 10, 2022

Conversation

weidankong
Copy link
Contributor

Description

update resume logic, change RUNNING/WAITING to WAITING (was FAILED).
send resume parameters to the tuner side, to allow deduplication logic work.

NOTE: currently only TPE tuner implemented the import_customized_data function.

Test Options

  • fast test
  • full test - HPO
  • full test - NAS
  • full test - compression

Checklist

  • test case
  • doc

How to test

  1. run the case: nnictl create --config examples/trials/mnist-pytorch/config.yml
  2. nnictl stop
  3. nnictl resume xxx
  4. check the status(waiting for the not finished trials), check the "Trial No."(keep original sequenceId/parameter_index)
  5. after all trials done, no duplicate params.

@QuanluZhang QuanluZhang requested review from QuanluZhang and removed request for QuanluZhang August 5, 2022 08:52
@QuanluZhang QuanluZhang merged commit d03c411 into microsoft:master Aug 10, 2022
ultmaster added a commit that referenced this pull request Sep 5, 2022
@ultmaster
Revert "[FEAT]: resume waiting/running, dedup on tuner side (TPE-only) (
bde0bbf 
#4931)"

This reverts commit d03c411.
@ultmaster ultmaster mentioned this pull request Sep 5, 2022
Merged
@QuanluZhang QuanluZhang mentioned this pull request Sep 6, 2022
Merged
@ultmaster ultmaster mentioned this pull request Sep 6, 2022
Closed
84 tasks
ultmaster added a commit that referenced this pull request Sep 6, 2022
@ultmaster
Revert "[FEAT]: resume waiting/running, dedup on tuner side (TPE-only…
23961a6 
…)" (#5111)

Revert "[FEAT]: resume waiting/running, dedup on tuner side (TPE-only) (#4931)"

This reverts commit d03c411.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J-shang J-shang J-shang approved these changes

@liuzhe-lz liuzhe-lz liuzhe-lz approved these changes

Assignees
No one assigned
Labels
v2.9
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@weidankong @J-shang @liuzhe-lz @QuanluZhang