-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable fixed_arch
on Retiarii
#3972
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skeletondyh
approved these changes
Jul 26, 2021
skeletondyh
suggested changes
Jul 26, 2021
@@ -19,7 +20,7 @@ class DartsLayerChoice(nn.Module): | |||
def __init__(self, layer_choice): | |||
super(DartsLayerChoice, self).__init__() | |||
self.name = layer_choice.key |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be layer_choice.label, otherwise there would be warning. DartsInputChoice should also be modified.
johsnows
approved these changes
Jul 27, 2021
jonsnows
approved these changes
Jul 27, 2021
skeletondyh
approved these changes
Jul 27, 2021
QuanluZhang
approved these changes
Jul 27, 2021
J-shang
approved these changes
Jul 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3969.
Added an API called
fixed_arch
to enable users to quickly use the exported architecture.I haven't tested on other trainers because their retraining code looks over complex. I'll do that as a follow-up task.