[Model Compression] fix compression doc and update a notebook example #3955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ultmaster
reviewed
Jul 21, 2021
| @@ -31,7 +31,7 @@ The specification of configuration can be found `here <./Tutorial.rst#specify-th | |||
| Step2. Choose a pruner and compress the model | |||
There was a problem hiding this comment.
I suggest that we can put the notebook into documentation to increase visibility.
There was a problem hiding this comment.
good suggestion, add this into the doc.
linbinskn
reviewed
Jul 26, 2021
| } | ||
| ], | ||
| "source": [ | ||
| "from nni.algorithms.compression.pytorch.quantization import DoReFaQuantizer\n", |
There was a problem hiding this comment.
Recommend using QAT_Quantizer instead of DoReFaQuantizer since quantization speedup only support QAT_Quantizer right now.
There was a problem hiding this comment.
got it, change to QAT_Quantizer
QuanluZhang
approved these changes
Jul 27, 2021
ultmaster
approved these changes
Jul 27, 2021
linbinskn
approved these changes
Jul 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.