Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix multi-thread event handling issue #3899

Merged
merged 1 commit into from
Jul 30, 2021
Merged

fix multi-thread event handling issue #3899

merged 1 commit into from
Jul 30, 2021

Conversation

QuanluZhang
Copy link
Contributor

@QuanluZhang QuanluZhang commented Jul 2, 2021 •
edited
Loading

  • fix the bug that sometimes retiarii experiment cannot exit successfully after finishing all the trials, because nnimanager requests more trials from dispatcher/strategy
  • fix incorrect order of items for cleaning up retiarii experiment
  • fully test the modification

@QuanluZhang QuanluZhang mentioned this pull request Jul 5, 2021
Closed
ultmaster
ultmaster approved these changes Jul 7, 2021
View reviewed changes
Copy link
Contributor

@ultmaster ultmaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not confident of this approve, because I have no idea why it works now and why it didn't work before.

@QuanluZhang QuanluZhang merged commit 6645bd3 into microsoft:master Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ultmaster ultmaster ultmaster approved these changes

@SparkSnail SparkSnail SparkSnail approved these changes

@liuzhe-lz liuzhe-lz liuzhe-lz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@QuanluZhang @ultmaster @SparkSnail @liuzhe-lz