Add several speedup examples #3880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 26, 2021 04:56
J-shang
reviewed
Jul 1, 2021
|
The file model_speedup.py can't be moved directly to the new folder speedup since |
linbinskn
reviewed
Jul 4, 2021
| NanoDet model can be installed from https://github.com/RangiLyu/nanodet.git | ||
| """ | ||
|
|
||
| cfg_path = r"nanodet/config/nanodet-RepVGG-A0_416.yml" |
There was a problem hiding this comment.
It is a little strange that user has to install model from other repo for running example. If this model is not very complicated, can we add it into our model compression model files so that user can run it directly.
There was a problem hiding this comment.
no need to put their code into our repo. but we can provide concrete commands about how to prepare the code in the comment
QuanluZhang
reviewed
Jul 9, 2021
| not_safe = not_safe_to_prune(model, dummy_input) | ||
| cfg_list = [] | ||
| for name, module in model.named_modules(): | ||
| if name in not_safe: |
There was a problem hiding this comment.
maybe we can leverage "exclude" here in the config, @J-shang
There was a problem hiding this comment.
Yes, exclude is much more elegant.
QuanluZhang
approved these changes
Jul 14, 2021
added 2 commits
July 14, 2021 09:25
J-shang
approved these changes
Jul 14, 2021
linbinskn
approved these changes
Jul 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a few common detection model examples (if the model written by the user fails to speedup, he/she can refer to the repo we gave).