add exclude config validate in compressor #3815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we have a documentation to describe the config interface of the pruner? Shall we give an example/unit test? |
| @@ -3,8 +3,9 @@ | |||
|
|
|||
| import logging | |||
| import copy | |||
| from nni.utils import OptimizeMode | |||
There was a problem hiding this comment.
What is OptimizeMode for? seems not used?
There was a problem hiding this comment.
yes, seems a mistake, remove it.
| }], model, _logger) | ||
|
|
||
| schema.validate(config_list) | ||
| for config in config_list: | ||
| if 'exclude' not in config and 'sparsity' not in config: |
There was a problem hiding this comment.
Only when both sparsity and op_types/op_names exists, this config is validate, right?
There was a problem hiding this comment.
yes, and you reminded me this way is not elegant, modify it.
QuanluZhang
reviewed
Jul 9, 2021
QuanluZhang
approved these changes
Jul 9, 2021
|
@J-shang please fix pipeline errors |
Yes, we have doc and ut, and add an exclude usecase in the example. |
QuanluZhang
approved these changes
Jul 12, 2021
zheng-ningxin
approved these changes
Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.