add python api example and update doc #3396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
94 tasks
liuzhe-lz
approved these changes
Feb 24, 2021
QuanluZhang
reviewed
Feb 25, 2021
| @@ -13,6 +13,7 @@ scikit-learn>=0.23.2 | |||
| websockets | |||
| filelock | |||
| prettytable | |||
| ipython | |||
There was a problem hiding this comment.
what is this file used for?
QuanluZhang
reviewed
Feb 25, 2021
|
|
||
| .. code:: ipython3 | ||
|
|
||
| experiment.connect(8080) |
There was a problem hiding this comment.
which one is correct? Experiment.connect()?
There was a problem hiding this comment.
for now, experiment.connect().
QuanluZhang
reviewed
Feb 25, 2021
nni/experiment/experiment.py
Outdated
| Return experiment metadata with specified exp_id as a dict. | ||
|
|
||
| Returns | ||
| ---------- |
QuanluZhang
reviewed
Feb 25, 2021
QuanluZhang
reviewed
Feb 25, 2021
nni/experiment/experiment.py
Outdated
| @@ -204,7 +204,7 @@ def run(self, port: int = 8080, debug: bool = False) -> bool: | |||
| finally: | |||
| self.stop() | |||
|
|
|||
| def connect_experiment(self, port: int): | |||
| def connect(self, port: int): | |||
There was a problem hiding this comment.
suggest to decorate it with @classmethod or @staticmethod
QuanluZhang
approved these changes
Feb 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A jupyter notebook example about
Experiment.start()andExperiment.connect().