Multiple Experiments Management UX #3127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
November 4, 2020 06:41
liuzhe-lz
reviewed
Dec 10, 2020
liuzhe-lz
reviewed
Dec 10, 2020
liuzhe-lz
reviewed
Dec 10, 2020
| className: 'tableHead leftTitle', | ||
| data: 'string', | ||
| onColumnClick: this.onColumnClick, | ||
| onRender: (item: any): React.ReactNode => <div className='succeed-padding'>{item.id}</div> |
There was a problem hiding this comment.
Suggest to make "ID" and "Status" (when running) clickable.
There was a problem hiding this comment.
discuss with xingyu, and now ID column is clickable.
liuzhe-lz
reviewed
Dec 10, 2020
| const webuiPortal = `${protocol}//${hostname}:${port}/oview`; | ||
| return ( | ||
| <div className='succeed-padding ellipsis'> | ||
| <a href={webuiPortal} className='link' target='_blank' rel='noopener noreferrer'> |
There was a problem hiding this comment.
The style should not be "blue with underline". It looks like 20th century......
There was a problem hiding this comment.
by design, i will discuss with Xingyu
There was a problem hiding this comment.
now, when cursor hover on the trial id, font change blue with underline
liuzhe-lz
reviewed
Dec 10, 2020
liuzhe-lz
reviewed
Dec 10, 2020
liuzhe-lz
reviewed
Dec 10, 2020
| </Stack> | ||
| <DetailsList | ||
| columns={this.columns} | ||
| items={source} |
There was a problem hiding this comment.
Is this supposed to be auto-refreshing?
There was a problem hiding this comment.
in this version, it has not auto-refresh
liuzhe-lz
reviewed
Dec 10, 2020
colorjam
approved these changes
Dec 11, 2020
liuzhe-lz
approved these changes
Dec 14, 2020
J-shang
approved these changes
Dec 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related issue #2779 #3100 #3055
### now, experiment still click
Namecolumn to other webui, also with<a>style.