Pretty JSON formatter #2863
Merged
Pretty JSON formatter #2863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ultmaster
reviewed
Sep 7, 2020
src/webui/src/static/json_util.ts
Outdated
| const fields = nonNull.map(obj => obj[key]).filter(v => v !== undefined); | ||
| let elements; | ||
| if (detectBatch(fields)) { // look like same field of class instances | ||
| elements = batchFormat(fields, indent + ' ', width, key); |
There was a problem hiding this comment.
Can we expose the interface of indent width?
There was a problem hiding this comment.
As long as it's not configurable in web UI, I think we can make life easier.
|
I thought it is to call |
|
@Lijiaoa please help review |
ultmaster
approved these changes
Sep 9, 2020
Lijiaoa
reviewed
Sep 10, 2020
| @@ -3671,7 +3671,7 @@ debug@^4.0.1, debug@^4.1.0, debug@^4.1.1: | |||
| dependencies: | |||
| ms "^2.1.1" | |||
|
|
|||
| debuglog@*, debuglog@^1.0.1: | |||
There was a problem hiding this comment.
could you remove yarn.lock changes? Because PR #2866 had same changes.
There was a problem hiding this comment.
yarn.lock is automatically modified on build.
I wonder why it's not committed by the PR which changes package.json...
|
PR #2880 had modifiy the rule |
Lijiaoa
approved these changes
Sep 11, 2020
chicm-ms
approved these changes
Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This util formats JSON basing on expected width.
Take following object as example:
{ "batch_size": {"_type": "choice", "_value": [16, 32, 64, 128]}, "hidden_size": {"_type": "choice", "_value": [128, 256, 512, 1024]}, "lr": {"_type": "choice", "_value": [0.0001, 0.001, 0.01, 0.1]}, "momentum": {"_type": "uniform", "_value": [0, 1]} }When the width is 60, it will be formatted as:
{ "batch_size": { "_type": "choice", "_value": [16, 32, 64, 128] }, "hidden_size": { "_type": "choice", "_value": [128, 256, 512, 1024] }, "lr": { "_type": "choice", "_value": [0.0001, 0.001, 0.01, 0.1] }, "momentum": { "_type": "uniform", "_value": [0, 1] } }When the width is 40, it will be:
{ "batch_size": { "_type": "choice", "_value": [ 16, 32, 64, 128 ] }, "hidden_size": { "_type": "choice", "_value": [ 128, 256, 512, 1024 ] }, "lr": { "_type": "choice", "_value": [ 0.0001, 0.001, 0.01, 0.1 ] }, "momentum": { "_type": "uniform", "_value": [ 0, 1 ] } }The
_valuearrays will always get collapsed or expanded together, since the util thinks they are "similar".