Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle ranging data notification #104

Merged
merged 17 commits into from
Mar 1, 2023
Merged

Handle ranging data notification #104

merged 17 commits into from
Mar 1, 2023

Conversation

forwardpointer
Copy link
Contributor

@forwardpointer forwardpointer commented Feb 28, 2023 •
edited
Loading

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Breaking change
  • Non-functional change
  • Documentation
  • Infrastructure

Goals

  • Calls the OnPeerPropertiesChanged callback when receiving new ranging data

Technical Details

  • Adds a conversion function from Q9.7 format to standard IEEE double format.

Test Results

None yet

Reviewer Focus

Test will be added for the conversion function

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@forwardpointer forwardpointer requested a review from a team as a code owner February 28, 2023 20:48
@forwardpointer forwardpointer changed the title Handle ranging Handle ranging data notification Feb 28, 2023
@forwardpointer forwardpointer mentioned this pull request Feb 28, 2023
Closed
10 tasks
abeltrano
abeltrano requested changes Feb 28, 2023
View reviewed changes
lib/uwb/UwbPeer.cxx Outdated Show resolved Hide resolved
lib/uwb/UwbPeer.cxx Outdated Show resolved Hide resolved
lib/uwb/UwbPeer.cxx Outdated Show resolved Hide resolved
lib/uwb/UwbSession.cxx Outdated Show resolved Hide resolved
lib/uwb/include/uwb/UwbPeer.hxx Show resolved Hide resolved
lib/uwb/UwbDevice.cxx Outdated Show resolved Hide resolved
lib/uwb/UwbPeer.cxx Outdated Show resolved Hide resolved
Base automatically changed from range_view to develop March 1, 2023 18:21
abeltrano
abeltrano reviewed Mar 1, 2023
View reviewed changes
lib/uwb/UwbPeer.cxx Outdated Show resolved Hide resolved
abeltrano
abeltrano previously approved these changes Mar 1, 2023
View reviewed changes
@forwardpointer
Copy link
Contributor Author

#107

@forwardpointer forwardpointer merged commit 4819235 into develop Mar 1, 2023
@forwardpointer forwardpointer deleted the handleRanging branch March 1, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abeltrano abeltrano abeltrano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@forwardpointer @abeltrano