Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a method to reject a TCP connection #4536

Merged
merged 1 commit into from
Sep 8, 2024
Merged

Conversation

ThadHouse
Copy link
Contributor

Description

Currently, it is impossible to reject a TCP connection. Calling CxPlatSocketDelete() from the Accept callback results in a use after free, and there isn't any way to detect that, other then to return a value from Accept()

Testing

New test added to cover this case.

Documentation

No, there is no documentation for TCP.

@ThadHouse ThadHouse requested a review from a team as a code owner September 8, 2024 00:25
Copy link

codecov bot commented Sep 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.91%. Comparing base (9f2f0d4) to head (9aaec8c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4536      +/-   ##
==========================================
- Coverage   86.19%   85.91%   -0.29%     
==========================================
  Files          56       56              
  Lines       15520    15520              
==========================================
- Hits        13378    13334      -44     
- Misses       2142     2186      +44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nibanks nibanks added the external Proposed by non-MSFT label Sep 8, 2024
@nibanks nibanks merged commit e5aa857 into microsoft:main Sep 8, 2024
470 of 471 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external Proposed by non-MSFT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants