Improve Thread Creation Logic

[nibanks]

Description

This PR improves various parts of thread creation in MsQuic. Most notably it adds the ability for apps to configure usage of high priority threads (not enabled by default). It also fixes/improves setting the ideal processor on systems with more than 64 procs in user mode. Also, it improves the default flags used in various places. Finally, it adds logs for various failures in thread creation.

Testing

Manual secnetperf over localhost.
CI/CD

Documentation

N/A

[ami-GS]

Is the fix for only winuser?

[nibanks]

Is the fix for only winuser?

Some of the fixes were.

[codecov]

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 85.12%. Comparing base (c0a739a) to head (7353024).
Report is 8 commits behind head on main.

Files with missing lines	Patch %	Lines
src/core/worker.c	50.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4531      +/-   ##
==========================================
- Coverage   86.24%   85.12%   -1.12%     
==========================================
  Files          56       56              
  Lines       15520    15527       +7     
==========================================
- Hits        13385    13218     -167     
- Misses       2135     2309     +174     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ProjectsByJackHe]

Looks really good!

Just 1 question.

Where did we get the confidence that there won't be any breaking changes in the "Scavenger" or "Real time" execution profile modes?

At least according to CodeCov bot those paths weren't exercised.

[nibanks]

Looks really good!

Just 1 question.

Where did we get the confidence that there won't be any breaking changes in the "Scavenger" or "Real time" execution profile modes?

At least according to CodeCov bot those paths weren't exercised.

AFAIK no one uses those execution modes, so we should be fine.