Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kqueue CSPLAT_SQE Type #4527

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Fix kqueue CSPLAT_SQE Type #4527

merged 2 commits into from
Sep 4, 2024

Conversation

ThadHouse
Copy link
Contributor

Description

kevent.ident is a uintptr_t, not an int. C didn't really care, but if C++ included quic_platform.h, an error would occur as narrowing from signed to unsigned in a designated initializer is an error in C++. Could be solved either by adding an explicit cast, or changing the type to be correct. Changing the type seemed like the better option.

Testing

Existing tests will cover it.

Documentation

N/A

@ThadHouse ThadHouse requested a review from a team as a code owner September 3, 2024 16:07
@nibanks nibanks added external Proposed by non-MSFT Bug: Platform A code bug in platform/TLS specific code. labels Sep 3, 2024
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.32%. Comparing base (22b7dda) to head (4a342e1).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4527      +/-   ##
==========================================
- Coverage   86.37%   86.32%   -0.05%     
==========================================
  Files          56       56              
  Lines       15515    15517       +2     
==========================================
- Hits        13401    13395       -6     
- Misses       2114     2122       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nibanks nibanks merged commit 8aaf2ea into microsoft:main Sep 4, 2024
456 of 470 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug: Platform A code bug in platform/TLS specific code. external Proposed by non-MSFT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants