-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prunable Pool Allocator #4517
Prunable Pool Allocator #4517
Conversation
@@ -696,12 +696,6 @@ TEST_F(DataPathTest, InitializeInvalid) | |||
ASSERT_EQ(QUIC_STATUS_INVALID_PARAMETER, Datapath.GetInitStatus()); | |||
ASSERT_EQ(nullptr, Datapath.Datapath); | |||
} | |||
if (!UseDuoNic) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test case is invalid if you have XDP installed locally (which I do).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WOW
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4517 +/- ##
==========================================
- Coverage 86.24% 85.06% -1.18%
==========================================
Files 56 56
Lines 15520 15520
==========================================
- Hits 13385 13202 -183
- Misses 2135 2318 +183 ☔ View full report in Codecov by Sentry. |
Description
Updates the datapath RX buffers (on Windows) to periodically prune items to keep from growing and holding on to too much memory.
Testing
CI/CD
Documentation
N/A