Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable logs to get the code coverage #3815

Merged
merged 1 commit into from
Aug 13, 2023
Merged

Conversation

nibanks
Copy link
Member

@nibanks nibanks commented Aug 12, 2023

Description

There are a lot of lines not executed in packet.c and frame.c that are related to logging. Enable those logs during code coverage.

Testing

Automation

Documentation

N/A

@nibanks nibanks requested a review from a team as a code owner August 12, 2023 23:30
@codecov
Copy link

codecov bot commented Aug 12, 2023

Codecov Report

Merging #3815 (9904590) into main (46b7512) will increase coverage by 1.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3815      +/-   ##
==========================================
+ Coverage   85.41%   86.49%   +1.07%     
==========================================
  Files          56       56              
  Lines       16543    16543              
==========================================
+ Hits        14131    14309     +178     
+ Misses       2412     2234     -178     

see 22 files with indirect coverage changes

@nibanks nibanks added Area: Testing Related to test coverage Area: Automation labels Aug 13, 2023
@nibanks nibanks enabled auto-merge (squash) August 13, 2023 00:08
Copy link
Contributor

@ami-GS ami-GS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome catch

@nibanks nibanks merged commit b092984 into main Aug 13, 2023
422 checks passed
@nibanks nibanks deleted the nibanks/code-coverage-log branch August 13, 2023 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Automation Area: Testing Related to test coverage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants