Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Loss and BBR Tests #3808

Merged
merged 6 commits into from
Aug 12, 2023
Merged

More Loss and BBR Tests #3808

merged 6 commits into from
Aug 12, 2023

Conversation

nibanks
Copy link
Member

@nibanks nibanks commented Aug 11, 2023

Description

While looking at code coverage, I noticed BBR doesn't have a lot of coverage. This PR is an attempt to improve code coverage in loss scenarios for it.

Testing

Tests updated

Documentation

N/A

@nibanks nibanks added the Area: Testing Related to test coverage label Aug 11, 2023
@nibanks nibanks requested a review from a team as a code owner August 11, 2023 18:51
@nibanks nibanks enabled auto-merge (squash) August 11, 2023 18:54
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #3808 (6a590ac) into main (6b70077) will increase coverage by 4.55%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3808      +/-   ##
==========================================
+ Coverage   80.65%   85.20%   +4.55%     
==========================================
  Files          56       56              
  Lines       15694    16543     +849     
==========================================
+ Hits        12658    14096    +1438     
+ Misses       3036     2447     -589     

see 44 files with indirect coverage changes

@nibanks nibanks merged commit 46b7512 into main Aug 12, 2023
403 of 407 checks passed
@nibanks nibanks deleted the nibanks/more-loss branch August 12, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Testing Related to test coverage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants