-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed the timeout number #3158
Conversation
lisa/schema.py
Outdated
@@ -1577,7 +1577,7 @@ class Runbook: | |||
tags: Optional[List[str]] = None | |||
concurrency: int = 1 | |||
# minutes to wait for resource | |||
wait_resource_timeout: float = 5 | |||
wait_resource_timeout: float = 10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can configure it in runbook. And don't mention internal work in GitHub.
50cd948
to
5c02d25
Compare
$sshd_config = "C:\ProgramData\ssh\sshd_config" | ||
(Get-Content $sshd_config) -replace '#PubkeyAuthentication', 'PubkeyAuthentication' | Out-File -encoding ASCII $sshd_config | ||
$ssh_server = Get-Service sshd | Where-Object { $_.Name -like 'sshd' -and $_.Status -like "Running" } | ||
if ($ssh_server) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does it mean, if ssh_server is not here? It may cause key auth changes are skipped.
@@ -149,7 +149,7 @@ def command(self) -> str: | |||
def _check_exists(self) -> bool: | |||
return True | |||
|
|||
def reboot(self, time_out: int = 600) -> None: | |||
def reboot(self, time_out: int = 1200) -> None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't need to change the default value. Specify the value when it's called.
lisa/tools/reboot.py
Outdated
@@ -174,7 +174,7 @@ def reboot(self, time_out: int = 600) -> None: | |||
constants.ENVIRONMENTS_NODES_REMOTE_PORT | |||
], | |||
log=self._log, | |||
timeout=20, | |||
timeout=1200, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
20 should be enough, in this loop it will try multiple times.
76e03b7
to
a582a9f
Compare
3a495d8
to
dd51ded
Compare
e1c8f60
to
6c70a2a
Compare
6c70a2a
to
57b8abb
Compare
@paulli2017 hi, are you planning to update this pull request? |
This change is not needed anymore |
test for kernel validation pipeline test